From: Jeff Chua <jeff.chua.linux@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Shanyu Zhao <shanyu.zhao@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>
Cc: stable@kernel.org, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [REVERT] be6b38bcb175613f239e0b302607db346472c6b6. v2.6.34-rc3-406 oops with 4965AGN wireless
Date: Fri, 9 Apr 2010 01:16:43 +0800 (SGT) [thread overview]
Message-ID: <Pine.LNX.4.64.1004090104570.7829@boston.corp.fedex.com> (raw)
Linus,
I'm having problem with the latest git pull 2 days ago with the 4965AGN
wireless.
Starting the wireless with WPA2 resulted in system hard freeze. Reverting
the commit below solves the problem.
Thanks,
Jeff
commit be6b38bcb175613f239e0b302607db346472c6b6
Author: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Date: Thu Mar 18 09:05:00 2010 -0700
iwlwifi: counting number of tfds can be free for 4965
Forget one hunk in 4965 during "iwlwifi: error checking for number of tfds
in queue" patch.
Reported-by: Shanyu Zhao <shanyu.zhao@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
CC: stable@kernel.org
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
index 1bd2cd8..83c52a6 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
@@ -2041,16 +2041,14 @@ static void iwl4965_rx_reply_tx(struct iwl_priv *priv,
tx_resp->failure_frame);
freed = iwl_tx_queue_reclaim(priv, txq_id, index);
- if (qc && likely(sta_id != IWL_INVALID_STATION))
- priv->stations[sta_id].tid[tid].tfds_in_queue -= freed;
+ iwl_free_tfds_in_queue(priv, sta_id, tid, freed);
if (priv->mac80211_registered &&
(iwl_queue_space(&txq->q) > txq->q.low_mark))
iwl_wake_queue(priv, txq_id);
}
- if (qc && likely(sta_id != IWL_INVALID_STATION))
- iwl_txq_check_empty(priv, sta_id, tid, txq_id);
+ iwl_txq_check_empty(priv, sta_id, tid, txq_id);
if (iwl_check_bits(status, TX_ABORT_REQUIRED_MSK))
IWL_ERR(priv, "TODO: Implement Tx ABORT REQUIRED!!!\n");
next reply other threads:[~2010-04-08 17:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 17:16 Jeff Chua [this message]
2010-04-08 17:19 ` Linus Torvalds
2010-04-08 19:47 ` Peter Zijlstra
2010-04-08 18:13 ` Al Viro
2010-04-08 20:09 ` Guy, Wey-Yi
2010-04-08 20:24 ` Guy, Wey-Yi
2010-04-08 18:50 ` Guy, Wey-Yi
2010-04-08 19:27 Jeff Chua
2010-04-08 19:42 ` Jeff Chua
2010-04-08 20:50 ` Guy, Wey-Yi
2010-04-08 20:02 ` John W. Linville
2010-04-08 21:28 ` Guy, Wey-Yi
[not found] ` <k2yb6a2187b1004081736td3a4c0f3uc05451902bec39a5@mail.gmail.com>
2010-04-09 3:15 ` Guy, Wey-Yi
2010-04-08 20:19 ` John W. Linville
2010-04-08 20:39 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1004090104570.7829@boston.corp.fedex.com \
--to=jeff.chua.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shanyu.zhao@intel.com \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®