From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: Michal Marek <mmarek@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: add *.rej pattern to .gitignore
Date: Wed, 21 Apr 2010 17:31:34 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1004211729150.5292@axis700.grange> (raw)
In-Reply-To: <20100421152837.GA13861@hack>
On Wed, 21 Apr 2010, Américo Wang wrote:
> On Wed, Apr 21, 2010 at 01:47:29PM +0200, Guennadi Liakhovetski wrote:
> >Tell git to ignore .rej files, generated by patch(1).
> >
> >Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> NACK.
>
> You have to handle *.rej files, not leaving them there.
Hm? I know I have to handle them, and I do handle them, but IMHO it's
entirely valid and up to the user to leave them where they are. You could
apply similar argument to *.orig or to *~ files. In other words, I'm not
convinced.
Thanks
Guennadi
> >---
> >diff --git a/.gitignore b/.gitignore
> >index a2939fc..17ababa 100644
> >--- a/.gitignore
> >+++ b/.gitignore
> >@@ -74,5 +74,6 @@ GSYMS
> > GTAGS
> >
> > *.orig
> >+*.rej
> > *~
> > \#*#
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
next prev parent reply other threads:[~2010-04-21 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 11:47 Guennadi Liakhovetski
2010-04-21 15:28 ` Américo Wang
2010-04-21 15:31 ` Guennadi Liakhovetski [this message]
2010-04-21 16:33 ` Américo Wang
2010-04-21 20:22 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1004211729150.5292@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®