From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754159Ab0EPJF3 (ORCPT ); Sun, 16 May 2010 05:05:29 -0400 Received: from mgw1.diku.dk ([130.225.96.91]:56941 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753203Ab0EPJF2 (ORCPT ); Sun, 16 May 2010 05:05:28 -0400 Date: Sun, 16 May 2010 11:05:23 +0200 (CEST) From: Julia Lawall To: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: ERR_PTR and PTR_ERR In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 16 May 2010, Julia Lawall wrote: > I see a number of occurrences of code like the following: > > if (IS_ERR(alg)) > return ERR_PTR(PTR_ERR(alg)); > > Is there any reason why the second line couldn't just be return alg? Hmm, never mind. It seems to address a type problem. julia