From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755243Ab0FBImm (ORCPT ); Wed, 2 Jun 2010 04:42:42 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:40812 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166Ab0FBImk (ORCPT ); Wed, 2 Jun 2010 04:42:40 -0400 Date: Wed, 2 Jun 2010 10:42:32 +0200 (CEST) From: Julia Lawall To: "Roedel, Joerg" Cc: Andrew Morton , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH 6/17] arch/x86/kernel: Add missing spin_unlock In-Reply-To: <20100602083837.GC21639@amd.com> Message-ID: References: <20100601141529.0c99f22c.akpm@linux-foundation.org> <20100602083837.GC21639@amd.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Jun 2010, Roedel, Joerg wrote: > Hi Andrew, > > On Tue, Jun 01, 2010 at 05:15:29PM -0400, Andrew Morton wrote: > > The reason why these bugs occur is that we sprinkle multiple `return' > > statements inside the middle of non-trivial functions. People miss > > some or fail to modify some when later changing locking rules and we > > gain bugs (or, similarly, resource leaks). > > Right. I changed that in Julia's patch too before merging it into my > tree. It is already in -tip. See > http://git.kernel.org/tip/84fe6c19e4a598e8071e3bd1b2c923454eae1268 Thanks. That looks fine. julia