mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Chua <jeff.chua.linux@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Eric Anholt <eric@anholt.net>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Commit 9b8c4a0b215e603497daebe8ecbc9b1f0f035808 broken X11 pointer
Date: Fri, 4 Jun 2010 15:53:56 +0800 (SGT)	[thread overview]
Message-ID: <Pine.LNX.4.64.1006041547530.2447@boston.corp.fedex.com> (raw)



The following commit broke X11 mouse pointer. Symptom is "mouse pointer" 
on X11 cannot change "shape" when positioned to the frames of xterm 
window.

Reverting it makes it work again.

Running on X.Org X Server 1.8.99. Xterm 258. Lenovo X201s.


Thanks,
Jeff


commit 9b8c4a0b215e603497daebe8ecbc9b1f0f035808
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu May 27 14:21:01 2010 +0100

     drm/i915: Avoid moving from CPU domain during pwrite

     We can avoid an early clflush when pwriting if we use the current CPU
     write domain rather than moving the object to the GTT domain for the
     purposes of the pwrite. This has the advantage of not flushing the
     presumably hot data that we want to upload into the bo, and of ascribing
     the clflush to the execution when profiling.

     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
     Signed-off-by: Eric Anholt <eric@anholt.net>

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 42866c0..4590c78 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -971,7 +971,8 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data,
  	if (obj_priv->phys_obj)
  		ret = i915_gem_phys_pwrite(dev, obj, args, file_priv);
  	else if (obj_priv->tiling_mode == I915_TILING_NONE &&
-		 dev->gtt_total != 0) {
+		 dev->gtt_total != 0 &&
+		 obj->write_domain != I915_GEM_DOMAIN_CPU) {
  		ret = i915_gem_gtt_pwrite_fast(dev, obj, args, file_priv);
  		if (ret == -EFAULT) {
  			ret = i915_gem_gtt_pwrite_slow(dev, obj, args,

             reply	other threads:[~2010-06-04  7:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04  7:53 Jeff Chua [this message]
2010-06-04 18:02 ` Nick Bowler
2010-06-04 18:26   ` Jeff Chua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1006041547530.2447@boston.corp.fedex.com \
    --to=jeff.chua.linux@gmail.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®