From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783Ab0GFFIR (ORCPT ); Tue, 6 Jul 2010 01:08:17 -0400 Received: from mgw1.diku.dk ([130.225.96.91]:54181 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752091Ab0GFFIQ (ORCPT ); Tue, 6 Jul 2010 01:08:16 -0400 Date: Tue, 6 Jul 2010 07:07:57 +0200 (CEST) From: Julia Lawall To: David Miller Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] drivers/net: correct valid flag In-Reply-To: <20100705.180349.112607097.davem@davemloft.net> Message-ID: References: <20100705.180349.112607097.davem@davemloft.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Jul 2010, David Miller wrote: > From: Julia Lawall > Date: Mon, 5 Jul 2010 17:07:15 +0200 (CEST) > > > From: Julia Lawall > > > > Elsewhere in the "optimized" functions, the "2" constants are used. > > NV_TX_VALID and NV_TX2_VALID have the same value. > > > > Signed-off-by: Julia Lawall > > > > --- > > diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c > > index 268ea4d..870c18b 100644 > > --- a/drivers/net/forcedeth.c > > +++ b/drivers/net/forcedeth.c > > @@ -2468,7 +2468,8 @@ static int nv_tx_done_optimized(struct net_device *dev, int limit) > > struct ring_desc_ex* orig_get_tx = np->get_tx.ex; > > > > while ((np->get_tx.ex != np->put_tx.ex) && > > - !((flags = le32_to_cpu(np->get_tx.ex->flaglen)) & NV_TX_VALID) && > > + !((flags = le32_to_cpu(np->get_tx.ex->flaglen)) & NV_TX2_VALID) > > + && > > (tx_work < limit)) { > > Please don't put that "&&" on a line by itself. I don't care if leaving it > on the previous line makes it exceed 80 columns, what you're doing here is > infinitely less pleasant to read. OK, I'll put it back. julia