mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-janitors@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Magnus Damm <damm@opensource.se>,
	linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: boards: mach-se: use IS_ERR() instead of NULL check
Date: Fri, 26 Nov 2010 18:38:23 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.1011261835500.16655@axis700.grange> (raw)
In-Reply-To: <1290791190-21358-1-git-send-email-segoon@openwall.com>

On Fri, 26 Nov 2010, Vasiliy Kulikov wrote:

> clk_get() returns ERR_PTR() on error, not NULL.
> 
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>

Yep, there are, probably, a couple more of these, similar to

http://marc.info/?t=128715350900002&r=1&w=2

Hardly required, but if you like:

Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

Thanks
Guennadi

> ---
>  Cannot compile this driver, so it is not tested at all.
> 
>  arch/sh/boards/mach-se/7724/setup.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/sh/boards/mach-se/7724/setup.c b/arch/sh/boards/mach-se/7724/setup.c
> index c31d228..6735305 100644
> --- a/arch/sh/boards/mach-se/7724/setup.c
> +++ b/arch/sh/boards/mach-se/7724/setup.c
> @@ -871,14 +871,14 @@ static int __init devices_setup(void)
>  
>  	/* set SPU2 clock to 83.4 MHz */
>  	clk = clk_get(NULL, "spu_clk");
> -	if (clk) {
> +	if (!IS_ERR(clk)) {
>  		clk_set_rate(clk, clk_round_rate(clk, 83333333));
>  		clk_put(clk);
>  	}
>  
>  	/* change parent of FSI A */
>  	clk = clk_get(NULL, "fsia_clk");
> -	if (clk) {
> +	if (!IS_ERR(clk)) {
>  		clk_register(&fsimcka_clk);
>  		clk_set_parent(clk, &fsimcka_clk);
>  		clk_set_rate(clk, 11000);
> -- 
> 1.7.0.4
> 
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

  reply	other threads:[~2010-11-26 17:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-26 17:06 Vasiliy Kulikov
2010-11-26 17:38 ` Guennadi Liakhovetski [this message]
2010-11-26 17:45   ` Vasiliy Kulikov
2010-11-27  2:23     ` Paul Mundt
2010-11-29  4:01       ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1011261835500.16655@axis700.grange \
    --to=g.liakhovetski@gmx.de \
    --cc=damm@opensource.se \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=segoon@openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®