mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julia Lawall <julia@diku.dk>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: "'Ben Dooks'" <ben-linux@fluff.org>,
	kernel-janitors@vger.kernel.org,
	"'Wim Van Sebroeck'" <wim@iguana.be>,
	linux-arm-kernel@lists.infradead.org,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH 1/2] drivers/watchdog/s3c2410_wdt.c: Convert release_resource to release_region/release_mem_region
Date: Mon, 28 Feb 2011 11:12:05 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.1102281110090.14560@pc-004.diku.dk> (raw)
In-Reply-To: <002e01cbd72f$448ac150$cda043f0$%kim@samsung.com>

On Mon, 28 Feb 2011, Kukjin Kim wrote:

> Julia Lawall wrote:
> > 
> > Request_mem_region should be used with release_mem_region, not
> > release_resource.
> > 
> > The semantic match that finds this problem is as follows:
> > (http://coccinelle.lip6.fr/)
> > 
> > // <smpl>
> > @@
> > expression x,E;
> > @@
> > *x = request_mem_region(...)
> > ... when != release_mem_region(x)
> >     when != x = E
> > * release_resource(x);
> > // </smpl>
> > 
> > Signed-off-by: Julia Lawall <julia@diku.dk>
> > 
> > ---
> >  drivers/watchdog/s3c2410_wdt.c |   19 ++++++++-----------
> >  1 file changed, 8 insertions(+), 11 deletions(-)
> > 
> > diff --git a/drivers/watchdog/s3c2410_wdt.c
> b/drivers/watchdog/s3c2410_wdt.c
> > index 25b39bf..95ae53d 100644
> > --- a/drivers/watchdog/s3c2410_wdt.c
> > +++ b/drivers/watchdog/s3c2410_wdt.c
> > @@ -402,7 +402,6 @@ static inline void s3c2410wdt_cpufreq_deregister(void)
> > 
> >  static int __devinit s3c2410wdt_probe(struct platform_device *pdev)
> >  {
> > -	struct resource *res;
> >  	struct device *dev;
> >  	unsigned int wtcon;
> >  	int started = 0;
> > @@ -416,20 +415,19 @@ static int __devinit s3c2410wdt_probe(struct
> > platform_device *pdev)
> > 
> >  	/* get the memory region for the watchdog timer */
> > 
> > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	if (res == NULL) {
> > +	wdt_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +	if (wdt_mem == NULL) {
> 
> Hmm...I think, 'res' is better for platform_get_resource().
> Do we _really_ need to change the name?...

wdt_mem is a global variable.  Is res a good name for a global variable?  
One could say wdt_mem = res, if that seems better.

julia

> >  		dev_err(dev, "no memory resource specified\n");
> >  		return -ENOENT;
> >  	}
> > 
> > -	size = resource_size(res);
> > -	wdt_mem = request_mem_region(res->start, size, pdev->name);
> > -	if (wdt_mem == NULL) {
> > +	size = resource_size(wdt_mem);
> > +	if (!request_mem_region(wdt_mem->start, size, pdev->name)) {
> 
> If we keep the name 'res', don't need to change above.
> 
> >  		dev_err(dev, "failed to get memory region\n");
> >  		return -EBUSY;
> >  	}
> > 
> > -	wdt_base = ioremap(res->start, size);
> > +	wdt_base = ioremap(wdt_mem->start, size);
> 
> Same as above.
> 
> >  	if (wdt_base == NULL) {
> >  		dev_err(dev, "failed to ioremap() region\n");
> >  		ret = -EINVAL;
> > @@ -524,8 +522,8 @@ static int __devinit s3c2410wdt_probe(struct
> > platform_device *pdev)
> >  	iounmap(wdt_base);
> > 
> >   err_req:
> > -	release_resource(wdt_mem);
> > -	kfree(wdt_mem);
> > +	release_mem_region(wdt_mem->start, size);
> 
> release_mem_region(res->start, size); ?
> 
> > +	wdt_mem = NULL;
> > 
> >  	return ret;
> >  }
> > @@ -545,8 +543,7 @@ static int __devexit s3c2410wdt_remove(struct
> > platform_device *dev)
> > 
> >  	iounmap(wdt_base);
> > 
> > -	release_resource(wdt_mem);
> > -	kfree(wdt_mem);
> > +	release_mem_region(wdt_mem->start, resource_size(wdt_mem));
> 
> release_mem_region(res->start, resource_size(res)); ?
>
> >  	wdt_mem = NULL;
> >  	return 0;
> >  }
> 
> 
> Thanks.
> 
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2011-02-28 10:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-26 16:34 Julia Lawall
2011-02-28 10:07 ` Kukjin Kim
2011-02-28 10:12   ` Julia Lawall [this message]
2011-03-18  8:11     ` Wim Van Sebroeck
2011-03-18  8:35       ` Julia Lawall
2011-03-18  9:12         ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1102281110090.14560@pc-004.diku.dk \
    --to=julia@diku.dk \
    --cc=ben-linux@fluff.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®