From: Julia Lawall <julia@diku.dk>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Vladimir Motyka <vladimir.motyka@gmail.com>,
cjb@laptop.org, kernel-janitors@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata'
Date: Tue, 10 May 2011 09:57:27 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1105100955580.4600@ask.diku.dk> (raw)
In-Reply-To: <BANLkTinhy7QwE0a40efJhHazmGSgitKVdw@mail.gmail.com>
On Tue, 10 May 2011, Andy Shevchenko wrote:
> On Mon, May 9, 2011 at 7:12 PM, Julia Lawall <julia@diku.dk> wrote:
> > I guess there is also a point at which idata has been successfully
> > allocated but idata->buf has not.
> And? kfree() simple ignores NULL pointers.
Unnecessarily calling a function suggests that calling that function is
necessary when it is not. But it is probably not a big deal, especially
for a well known function like kfree.
julia
> I would prefer to see previous version of patch, but let maintainer to choose.
>
> --
> With Best Regards,
> Andy Shevchenko
>
prev parent reply other threads:[~2011-05-10 7:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 14:05 Vladimir Motyka
2011-05-09 14:32 ` Julia Lawall
2011-05-09 15:05 ` Vladimir Motyka
2011-05-09 15:13 ` Andy Shevchenko
2011-05-09 15:14 ` Julia Lawall
2011-05-09 16:08 ` Vladimir Motyka
2011-05-09 16:12 ` Julia Lawall
2011-05-09 20:37 ` Vladimir Motyka
2011-05-09 20:37 ` Vladimir Motyka
2011-05-11 4:03 ` Chris Ball
2011-05-10 7:47 ` Andy Shevchenko
2011-05-10 7:57 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1105100955580.4600@ask.diku.dk \
--to=julia@diku.dk \
--cc=andy.shevchenko@gmail.com \
--cc=cjb@laptop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=vladimir.motyka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®