From: Julia Lawall <julia@diku.dk>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Karsten Keil <isdn@linux-pingi.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: question about drivers/isdn/hisax/st5481_init.c
Date: Fri, 13 May 2011 15:35:20 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1105131535070.20447@pc-004.diku.dk> (raw)
In-Reply-To: <1305292826.4065.443.camel@localhost>
On Fri, 13 May 2011, Ben Hutchings wrote:
> On Fri, 2011-05-13 at 07:53 +0200, Julia Lawall wrote:
> > The function probe_st5481 allocates an adapter value using kzalloc, adds
> > it to adapter_list, and then performs various initialization operations,
> > which may fail. adapter_list is a static variable that is never otherwise
> > referenced in the file. There is a list_del that removes the adapter from
> > the list in the function disconnect_st5481. The presence of the adapter
> > on the list makes it possibly unsafe to free adapter in the failure cases.
> >
> > Could the list just be removed, if it is not being used anywhere?
> >
> > Or if the list should be kept because it is useful or it is planned to be
> > useful in the future, could the insertion into the list be moved to the
> > end of the function, after the potentially failing operations, so that
> > adapter can be freed when a failure occurs?
>
> Some older drivers have these device lists hanging around from before
> the device model has implemented. If the list isn't being used now then
> it's probably fine to remove.
OK, I'll propose a patch in that direction. Thanks.
julia
prev parent reply other threads:[~2011-05-13 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 5:53 Julia Lawall
2011-05-13 13:20 ` Ben Hutchings
2011-05-13 13:35 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1105131535070.20447@pc-004.diku.dk \
--to=julia@diku.dk \
--cc=bhutchings@solarflare.com \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®