Re: [PATCH] drivers/usb/gadget/inode.c: add missing kfree

[Julia Lawall <julia@diku.dk>]

On Thu, 2 Jun 2011, Alan Stern wrote:

> On Thu, 2 Jun 2011, Julia Lawall wrote:
> 
> > From: Julia Lawall <julia@diku.dk>
> > 
> > The label fail frees dev->buf, but kbuf hasn't yet been stored there at
> > this point.
> 
> ...
> 
> > Signed-off-by: Julia Lawall <julia@diku.dk>
> > 
> > ---
> > I wonder if it is really correct to free dev->buf at fail in this case.
> > Because it is freeing the previously allocated value of dev->buf, not the
> > current one as done in subsequent cases.
> 
> I don't think it matters.  This check is probably there only for 
> safety; it should not be possible for dev->buf to be non-NULL at this 
> point.  You ought to be able to remove the entire
> 
> 	if (dev->buf)
> 		goto fail;
> 
> statement with no ill effects.

I can send such a patch if you think it is OK.  But I have no way to test 
it.

julia