mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ian Molton <ian@mnementh.co.uk>,
	Chris Ball <cjb@laptop.org>,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: tmio: eliminate unused variable 'mmc' warning
Date: Wed, 3 Aug 2011 09:26:25 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.1108030924440.28502@axis700.grange> (raw)
In-Reply-To: <1312354138.14329.1.camel@phoenix>

On Wed, 3 Aug 2011, Axel Lin wrote:

> Fix below compile warning:
>   CC      drivers/mmc/host/tmio_mmc.o
> drivers/mmc/host/tmio_mmc.c: In function 'tmio_mmc_suspend':
> drivers/mmc/host/tmio_mmc.c:30: warning: unused variable 'mmc'
> drivers/mmc/host/tmio_mmc.c: In function 'tmio_mmc_resume':
> drivers/mmc/host/tmio_mmc.c:45: warning: unused variable 'mmc'
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Good for 3.1, do we also push such "harmless" compiler warning fixes to 
stable?

Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

Thanks
Guennadi

> ---
>  drivers/mmc/host/tmio_mmc.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
> index 8d185de..44a9668 100644
> --- a/drivers/mmc/host/tmio_mmc.c
> +++ b/drivers/mmc/host/tmio_mmc.c
> @@ -27,7 +27,6 @@
>  static int tmio_mmc_suspend(struct platform_device *dev, pm_message_t state)
>  {
>  	const struct mfd_cell *cell = mfd_get_cell(dev);
> -	struct mmc_host *mmc = platform_get_drvdata(dev);
>  	int ret;
>  
>  	ret = tmio_mmc_host_suspend(&dev->dev);
> @@ -42,7 +41,6 @@ static int tmio_mmc_suspend(struct platform_device *dev, pm_message_t state)
>  static int tmio_mmc_resume(struct platform_device *dev)
>  {
>  	const struct mfd_cell *cell = mfd_get_cell(dev);
> -	struct mmc_host *mmc = platform_get_drvdata(dev);
>  	int ret = 0;
>  
>  	/* Tell the MFD core we are ready to be enabled */
> -- 
> 1.7.4.1
> 
> 
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

  reply	other threads:[~2011-08-03  7:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-03  6:48 Axel Lin
2011-08-03  7:26 ` Guennadi Liakhovetski [this message]
2011-08-03 12:55   ` Chris Ball
2011-08-27 19:02     ` Ian Molton
2011-08-28 18:20       ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1108030924440.28502@axis700.grange \
    --to=g.liakhovetski@gmx.de \
    --cc=axel.lin@gmail.com \
    --cc=cjb@laptop.org \
    --cc=ian@mnementh.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®