From: Julia Lawall <julia@diku.dk>
To: Dan Carpenter <error27@gmail.com>
Cc: Paul Moore <paul@paul-moore.com>,
kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/netlabel/netlabel_kapi.c: add missing cleanup code
Date: Thu, 11 Aug 2011 11:52:41 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1108111152130.18938@ask.diku.dk> (raw)
In-Reply-To: <20110811094407.GG3777@shale.localdomain>
On Thu, 11 Aug 2011, Dan Carpenter wrote:
> On Thu, Aug 11, 2011 at 11:40:33AM +0200, Julia Lawall wrote:
> > From: Julia Lawall <julia@diku.dk>
> >
> > Use the same cleanup code for the failure of kzalloc as for the failure of
> > kstrdup just below.
> >
>
> That doesn't work. The kfree(entry->domain) would cause an oops.
Of course... Thanks!
julia
next prev parent reply other threads:[~2011-08-11 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 9:40 Julia Lawall
2011-08-11 9:44 ` Dan Carpenter
2011-08-11 9:52 ` Julia Lawall [this message]
2011-08-11 10:06 ` Julia Lawall
2011-08-11 12:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1108111152130.18938@ask.diku.dk \
--to=julia@diku.dk \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®