From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752374Ab1IVHik (ORCPT ); Thu, 22 Sep 2011 03:38:40 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:50361 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580Ab1IVHij (ORCPT ); Thu, 22 Sep 2011 03:38:39 -0400 Date: Thu, 22 Sep 2011 09:35:42 +0200 (CEST) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Josh Wu cc: linux-media@vger.kernel.org, plagnioj@jcrosoft.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nicolas.ferre@atmel.com, s.nawrocki@samsung.com Subject: Re: [PATCH v3 2/2] at91: add Atmel ISI and ov2640 support on sam9m10/sam9g45 board. In-Reply-To: <1316664661-11383-2-git-send-email-josh.wu@atmel.com> Message-ID: References: <1316664661-11383-1-git-send-email-josh.wu@atmel.com> <1316664661-11383-2-git-send-email-josh.wu@atmel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Provags-ID: V02:K0:cgK5pAOewsLkDpihpfIc3JerDJKBS++crEEo0dwTPG2 3Fk+AQcULxQ/LDV8WvxRx+mOvpG3jQ6tdMhOTmAHzjjlvuzjIg sPUcJlFGl5kz3wJ7HzTe7fcNpxX+7bgIziUOhZRi8pOOecfVKt j/cVHG2hngqvEkx3Z/qwAEaxrwql0l7zwytS5AMrg2/Jm7p+uR IMDqa/lx26BE+UCen/3/t3QYTF/ZfR/Mz5fCNWBZ16M81jsMhq byhEWhMDD7HYKREWm4//6pzkLeEJ1HgtZ4vJaxiJilpbL/W2lh 3jFQAIMEfKaLWdRv3BSwNdadyT5mdc/dOGHM9T+iSzJa7dRn+D LZvgAPNsx33XXw9pJDo0NzWer8nx5BP5LnaziU6KXx8jlhEFk9 G9svcwSkvBf4g== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Sep 2011, Josh Wu wrote: > This patch > 1. add ISI_MCK parent setting code when add ISI device. > 2. add ov2640 support on board file. > 3. define isi_mck clock in sam9g45 chip file. > > Signed-off-by: Josh Wu > --- > arch/arm/mach-at91/at91sam9g45.c | 3 + > arch/arm/mach-at91/at91sam9g45_devices.c | 105 +++++++++++++++++++++++++++++- > arch/arm/mach-at91/board-sam9m10g45ek.c | 85 ++++++++++++++++++++++++- > arch/arm/mach-at91/include/mach/board.h | 3 +- Personally, I think, it would be better to separate this into two patches at least: one for at91 core and one for the specific board, but that's up to arch maintainers to decide. You also want to patch arch/arm/mach-at91/at91sam9263_devices.c, don't you? > 4 files changed, 193 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-at91/at91sam9g45.c b/arch/arm/mach-at91/at91sam9g45.c > index e04c5fb..5e23d6d 100644 > --- a/arch/arm/mach-at91/at91sam9g45.c > +++ b/arch/arm/mach-at91/at91sam9g45.c > @@ -201,6 +201,7 @@ static struct clk *periph_clocks[] __initdata = { > // irq0 > }; > > +static struct clk pck1; Hm, it really doesn't need any initialisation, not even for the .type field? .type=0 doesn't seem to be valid. > static struct clk_lookup periph_clocks_lookups[] = { > /* One additional fake clock for ohci */ > CLKDEV_CON_ID("ohci_clk", &uhphs_clk), > @@ -215,6 +216,8 @@ static struct clk_lookup periph_clocks_lookups[] = { > CLKDEV_CON_DEV_ID("t0_clk", "atmel_tcb.1", &tcb0_clk), > CLKDEV_CON_DEV_ID("pclk", "ssc.0", &ssc0_clk), > CLKDEV_CON_DEV_ID("pclk", "ssc.1", &ssc1_clk), > + /* ISI_MCK, which is provided by programmable clock(PCK1) */ > + CLKDEV_CON_DEV_ID("isi_mck", "atmel_isi.0", &pck1), > }; > > static struct clk_lookup usart_clocks_lookups[] = { > diff --git a/arch/arm/mach-at91/at91sam9g45_devices.c b/arch/arm/mach-at91/at91sam9g45_devices.c > index 600bffb..82eeac8 100644 > --- a/arch/arm/mach-at91/at91sam9g45_devices.c > +++ b/arch/arm/mach-at91/at91sam9g45_devices.c > @@ -16,7 +16,7 @@ > #include > #include > #include > - > +#include > #include > #include