From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754798Ab1KHK1w (ORCPT ); Tue, 8 Nov 2011 05:27:52 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:56724 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741Ab1KHK1u (ORCPT ); Tue, 8 Nov 2011 05:27:50 -0500 Date: Tue, 8 Nov 2011 11:27:43 +0100 (CET) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: "Rafael J. Wysocki" cc: Linux PM list , LKML , Linux-sh list , Magnus Damm , Kevin Hilman , jean.pihet@newoldbits.com Subject: Re: [PATCH 2/7] PM / Domains: Make it possible to use per-device .active_wakeup() In-Reply-To: <201111070106.52411.rjw@sisk.pl> Message-ID: References: <201111070101.33960.rjw@sisk.pl> <201111070106.52411.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Provags-ID: V02:K0:9KZ9mjogDvXZEjuzO2hZAH2ZYHhhYMFw9TUIxLayrTL tsl9WW37VSsKhlZW9FK7aycCh5bpRoUEuGUcCc20scOHOsNNWg Lq/fzyrIF9gZTt/bhhK3+7OjSonDLHBxDWvJ1DSZCORTAAZI4+ Vz7F/JMQBfqinh8elSVBNCFc5F8fc3qVcdOnCrIB2lzal2HxJ2 DgPNoDXy956cJt3Dzp7YyFpwDYT5hmceIxunvttQv8O4K9M8Mt VoFI7joj4KWyUCO8B8OJ/SR48bh9zNhsVIII5wB0zuDwmgk/um 7QlQ/fQwMmBbJHq9oj3WsnYY5s6flRT0s0+GevuGC7cnzoTYFO SvvenQb5g+MzWrMqjVmbgK2TlGxzxZrD+pzwtgsYoSUEU5ZRoF lkE6sqwm7KyqQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Nov 2011, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The current generic PM domains code requires that the same > .active_wakeup() device callback routine be used for all devices in > the given domain, which is inflexible and may not cover some specific > use cases. For this reason, make it possible to use device specific > .active_wakeup() callback routines by adding a corresponding callback > pointer to struct generic_pm_domain_data. To reduce code duplication > use struct gpd_dev_ops to represent PM domain device callbacks as > well as device-specific ones and add a macro for defining routines > that will execute those callbacks. > > Modify the shmobile's power domains code to allow drivers to use > their own .active_wakeup() callback routines. > > Signed-off-by: Rafael J. Wysocki > --- > arch/arm/mach-shmobile/pm-sh7372.c | 11 ++++--- > drivers/base/power/domain.c | 54 ++++++++++++++++++------------------- > include/linux/pm_domain.h | 15 ++++------ > 3 files changed, 41 insertions(+), 39 deletions(-) > > Index: linux/include/linux/pm_domain.h > =================================================================== > --- linux.orig/include/linux/pm_domain.h > +++ linux/include/linux/pm_domain.h > @@ -23,6 +23,12 @@ struct dev_power_governor { > bool (*power_down_ok)(struct dev_pm_domain *domain); > }; > > +struct gpd_dev_ops { > + int (*start)(struct device *dev); > + int (*stop)(struct device *dev); > + bool (*active_wakeup)(struct device *dev); > +}; > + > struct generic_pm_domain { > struct dev_pm_domain domain; /* PM domain operations */ > struct list_head gpd_list_node; /* Node in the global PM domains list */ > @@ -45,9 +51,7 @@ struct generic_pm_domain { > bool dev_irq_safe; /* Device callbacks are IRQ-safe */ > int (*power_off)(struct generic_pm_domain *domain); > int (*power_on)(struct generic_pm_domain *domain); > - int (*start_device)(struct device *dev); > - int (*stop_device)(struct device *dev); > - bool (*active_wakeup)(struct device *dev); > + struct gpd_dev_ops dev_ops; Wouldn't it be better to merge patches 1 and 2? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/