From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753931Ab2CUDo7 (ORCPT ); Tue, 20 Mar 2012 23:44:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35801 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752535Ab2CUDo5 (ORCPT ); Tue, 20 Mar 2012 23:44:57 -0400 Date: Tue, 20 Mar 2012 23:44:47 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file.rdu.redhat.com To: Mandeep Singh Baines cc: device-mapper development , Steffen Klassert , Will Drewry , linux-kernel@vger.kernel.org, Elly Jones , Olof Johansson , Andrew Morton , Alasdair G Kergon , Milan Broz Subject: Re: [dm-devel] [PATCH] dm: remake of the verity target In-Reply-To: Message-ID: References: <1330648393-20692-1-git-send-email-msb@chromium.org> <20120306215947.GB27051@google.com> <20120320154159.GD27051@google.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Mar 2012, Mandeep Singh Baines wrote: > But we are hashing fixed-sized blocks so there is no possibility of extension. If the first part of some block contains some security-sensitive data and the last part of the same block can be attacker-controlled, he can use the collision attack to change the security-sensitive data. > However, better safe than sorry. I guess we'll just have to deal with > backward incompatibility. So feel free to add my sign off to the new > patch also. > > Signed-off-by: Mandeep Singh Baines > > Regards, > Mandeep > > > Mikulas I can introduce a switch to make it accept the old format. Do you want to? Mikulas