From: Mikulas Patocka <mpatocka@redhat.com>
To: Matt Turner <mattst88@gmail.com>
Cc: torvalds@linux-foundation.org, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Rolf Eike Beer <eike-kernel@sf-tec.de>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>
Subject: Re: [PATCH 5/5] PA-RISC: fix compile errors
Date: Wed, 9 May 2012 18:34:06 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.1205091832420.1272@file.rdu.redhat.com> (raw)
In-Reply-To: <CAEdQ38H4MjAGKYW3jbcRs98qKnikPwgN_0k2KWbK8wLmJa8xxQ@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2362 bytes --]
On Wed, 9 May 2012, Matt Turner wrote:
> On Wed, May 9, 2012 at 6:19 PM, Mikulas Patocka <mpatocka@redhat.com> wrote:
> > From: Rolf Eike Beer <eike-kernel@sf-tec.de>
> >
> > This was defined in asm/pdc.h which needs to include asm/page.h for
> > __PAGE_OFFSET. This leads to an include loop so that page.h eventually will
> > include pdc.h again. While this is no problem because of header guards, it is
> > a problem because some symbols may be undefined. Such an error is this:
> >
> > In file included from /home/buildbot/repos/linux/include/linux/bitops.h:35:0,
> > from /home/buildbot/repos/linux/include/asm-generic/getorder.h:7,
> > from /home/buildbot/repos/linux/arch/parisc/include/asm/page.h:162,
> > from /home/buildbot/repos/linux/arch/parisc/include/asm/pdc.h:346,
> > from /home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:16,
> > from /home/buildbot/repos/linux/arch/parisc/include/asm/spinlock.h:6,
> > from /home/buildbot/repos/linux/arch/parisc/include/asm/atomic.h:20,
> > from /home/buildbot/repos/linux/include/linux/atomic.h:4,
> > from /home/buildbot/repos/linux/include/linux/sysfs.h:20,
> > from /home/buildbot/repos/linux/include/linux/kobject.h:21,
> > from /home/buildbot/repos/linux/include/linux/device.h:17,
> > from /home/buildbot/repos/linux/include/linux/eisa.h:5,
> > from /home/buildbot/repos/linux/arch/parisc/kernel/pci.c:11:
> > /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h: In function "set_bit":
> > /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h:82:2: error: implicit declaration of function "_atomic_spin_lock_irqsave" [-Werror=implicit-function-declaration]
> > /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h:84:2: error: implicit declaration of function "_atomic_spin_unlock_irqrestore" [-Werror=implicit-function-declaration]
> >
> > Signed-off-by: Rolf Eike Beer <eike-kernel@xxxxxxxxx>
>
> Email address got eaten?
I was copying the patch from mailing list web archive and it mangles
addresses. I fixed the others addresses, but forgot about this one.
Mikulas
> > Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
>
next prev parent reply other threads:[~2012-05-09 22:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 22:16 [PATCH 1/5] " Mikulas Patocka
2012-05-09 22:17 ` [PATCH 2/5] " Mikulas Patocka
2012-05-09 22:17 ` [PATCH 3/5] " Mikulas Patocka
2012-05-09 22:18 ` [PATCH 4/5] " Mikulas Patocka
2012-05-09 22:19 ` [PATCH 5/5] " Mikulas Patocka
2012-05-09 22:22 ` Matt Turner
2012-05-09 22:34 ` Mikulas Patocka [this message]
2012-05-09 22:35 ` Mikulas Patocka
2012-05-10 6:44 ` [PATCH 1/5] " Rolf Eike Beer
2012-05-10 16:24 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1205091832420.1272@file.rdu.redhat.com \
--to=mpatocka@redhat.com \
--cc=deller@gmx.de \
--cc=eike-kernel@sf-tec.de \
--cc=jejb@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®