mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
	linux-samsung-soc@vger.kernel.org, patches@linaro.org,
	linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
	grant.likely@secretlab.ca, kgene.kim@samsung.com, cjb@laptop.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/7] mmc: dw_mmc: add device tree support
Date: Sat, 12 May 2012 21:31:31 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.1205122117340.11826@axis700.grange> (raw)
In-Reply-To: <CAJuYYwQj7gzZ9piJAJLcf7SiyJnQ6nZ63-X9ieQ-FCj6TNhQPQ@mail.gmail.com>

Hi Thomas

On Sat, 12 May 2012, Thomas Abraham wrote:

> On 4 May 2012 04:18, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> >
> > What do you think about this patch
> >
> > http://www.spinics.net/lists/linux-sh/msg11259.html
> >
> > and about using mmc-generic OF properties instead of creating yet another
> > copy of proprietary ones?
> 
> Hi Guennadi,
> 
> This patch does not intend to add any custom mmc properties. I checked
> your patch (in the link mentioned above) and most of the bindings are
> similar to what you have come up with except for the "ro-gpios" for
> which I have used "wp-gpios". But this is following what Arnd had
> proposed here: http://www.spinics.net/lists/linux-mmc/msg13564.html.

Thanks for the link! I didn't know about that patch.

> Regarding the MMC_CAP_4_BIT_DATA and MMC_CAP_8_BIT_DATA in your patch,
> these can be derived from the bus width information that the driver
> receives.

Sure. I think, my patch, that I mentioned above, shall be dropped, at 
least in its present form. But if at least in principle we do want to have 
a common MMC OF parser for common bindings, some code from your patch 
would become redundant, I think. BTW, isn't this

+	gpio = of_get_named_gpio(np, "wp_gpios", 0);

a typo? Shouldn't it be "wp-gpios" instead?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

  reply	other threads:[~2012-05-12 19:31 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-02  5:07 [PATCH 0/7] mmc: dw_mmc: add support for device tree based instantiation Thomas Abraham
2012-05-02  5:07 ` [PATCH 1/7] mmc: dw_mmc: lookup for optional biu and ciu clocks Thomas Abraham
2012-05-02  9:17   ` Will Newton
2012-05-10  9:11     ` Thomas Abraham
2012-05-02  9:53   ` Russell King - ARM Linux
2012-05-10  9:12     ` Thomas Abraham
2012-05-02 14:53   ` James Hogan
2012-05-10  9:20     ` Thomas Abraham
2012-05-10 13:43     ` Russell King - ARM Linux
2012-05-02  5:07 ` [PATCH 2/7] mmc: dw_mmc: add quirk to indicate missing write protect line Thomas Abraham
2012-05-02  9:10   ` Will Newton
2012-05-02  5:07 ` [PATCH 3/7] mmc: dw_mmc: add device tree support Thomas Abraham
2012-05-02  6:55   ` Kyungmin Park
2012-05-10  9:42     ` Thomas Abraham
2012-05-10  9:59       ` Kyungmin Park
2012-05-10 10:12         ` Thomas Abraham
2012-05-02 18:07   ` Olof Johansson
2012-05-10 10:15     ` Thomas Abraham
2012-05-12  7:07       ` Olof Johansson
2012-05-12  8:43         ` Thomas Abraham
2012-05-03 22:48   ` Guennadi Liakhovetski
2012-05-12  7:01     ` Thomas Abraham
2012-05-12 19:31       ` Guennadi Liakhovetski [this message]
2012-05-17 15:39         ` Thomas Abraham
2012-05-10 10:32   ` James Hogan
2012-05-10 10:44     ` Thomas Abraham
2012-05-02  5:07 ` [PATCH 4/7] mmc: dw_mmc: add samsung exynos5250 specific extentions Thomas Abraham
2012-05-02  7:01   ` Kyungmin Park
2012-05-02  7:49     ` Jaehoon Chung
2012-05-10 10:55       ` Thomas Abraham
2012-05-10 11:17         ` Jaehoon Chung
2012-05-10 10:38     ` Thomas Abraham
2012-05-02 18:10   ` Olof Johansson
2012-05-10 10:55     ` Thomas Abraham
2012-05-02  5:07 ` [PATCH 5/7] ARM: Samsung: Add support for MSHC controller clocks Thomas Abraham
2012-05-02  7:04   ` Kyungmin Park
2012-05-02  5:07 ` [PATCH 6/7] ARM: Exynos5: Add AUXDATA support for MSHC controllers Thomas Abraham
2012-05-02  5:07 ` [PATCH 7/7] ARM: dts: Add nodes for dw_mmc controllers for Samsung Exynos5250 platforms Thomas Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1205122117340.11826@axis700.grange \
    --to=g.liakhovetski@gmx.de \
    --cc=cjb@laptop.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=rob.herring@calxeda.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®