mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Vinod Koul <vinod.koul@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Paul Mundt <lethal@linux-sh.org>,
	"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH 1/9 v3] dmaengine: add an shdma-base library
Date: Fri, 25 May 2012 12:59:44 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.1205251255310.13353@axis700.grange> (raw)
In-Reply-To: <4FBF5EA9.704@nvidia.com>

Hi Laxman

On Fri, 25 May 2012, Laxman Dewangan wrote:

> On Friday 25 May 2012 01:45 PM, Vinod Koul wrote:
> > On Fri, 2012-05-18 at 10:21 +0200, Guennadi Liakhovetski wrote:
> 
> > +/*
> > > > > + * Drivers, using this library are expected to embed struct
> > > > > shdma_dev,
> > > > > + * struct shdma_chan, struct shdma_desc, and struct shdma_slave
> > > > > + * in their respective device, channel, descriptor and slave objects.
> > > > > + */
> > > > > +
> > > > > +struct shdma_slave {
> > > > > +	unsigned int slave_id;
> > > > this should be moved to struct dma_slave_config
> > > Again, this would be a functional change. And struct dma_slave_config
> > > doesn't have a slave-ID field in it, which is the only thing we need for
> > > now. Instead it has a bunch of other fields, of which none is so far used
> > > by this driver.
> > > 
> 
> In Nvidia's tegra SOC also require to pass the slave id from client to dma
> driver. I have pushed the change to make it part of struct dma_slave_config
> on the patch
> [PATCH V4 1/2] dma: dmaengine: add slave req id in slave_config
> 
> So hope you can use the same if that patch get merged.

Thanks for letting me know. After both our series get merged, when working 
on removal of .private use, switching to your new .slave_id will really be 
the way to go for us.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

  reply	other threads:[~2012-05-25 11:00 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 15:09 [PATCH 0/9 v3] extract an shdma base library from shdma.c Guennadi Liakhovetski
2012-05-09 15:09 ` [PATCH 1/9 v3] dmaengine: add an shdma-base library Guennadi Liakhovetski
2012-05-15  4:22   ` Vinod Koul
2012-05-18  8:21     ` Guennadi Liakhovetski
2012-05-25  8:15       ` Vinod Koul
2012-05-25  8:30         ` Guennadi Liakhovetski
2012-06-28  8:52           ` Guennadi Liakhovetski
2012-07-02 20:28             ` Guennadi Liakhovetski
2012-07-02 20:30               ` [PATCH 0.5/9] dma: move shdma driver to an own directory Guennadi Liakhovetski
2012-07-13  3:26               ` [PATCH 1/9 v3] dmaengine: add an shdma-base library Vinod Koul
2012-07-16  5:58               ` Vinod Koul
2012-05-25 10:27         ` Laxman Dewangan
2012-05-25 10:59           ` Guennadi Liakhovetski [this message]
2012-05-09 15:09 ` [PATCH 2/9 v3] dma: shdma: prepare for conversion to the shdma base library Guennadi Liakhovetski
2012-05-15  4:23   ` Vinod Koul
2012-05-18  8:21     ` Guennadi Liakhovetski
2012-05-09 15:09 ` [PATCH 3/9 v3] mmc: sh_mmcif: remove unneeded struct sh_mmcif_dma, prepare to shdma conversion Guennadi Liakhovetski
2012-07-05 17:35   ` Chris Ball
2012-05-09 15:09 ` [PATCH 4/9 v3] mmc: sh_mobile_sdhi: prepare for conversion to the shdma base library Guennadi Liakhovetski
2012-07-05 17:37   ` Chris Ball
2012-05-09 15:09 ` [PATCH 5/9 v3] serial: sh-sci: " Guennadi Liakhovetski
2012-05-10  3:09   ` Paul Mundt
2012-05-15  4:27   ` Vinod Koul
2012-05-18  8:21     ` Guennadi Liakhovetski
2012-05-09 15:09 ` [PATCH 6/9 v3] ASoC: siu: " Guennadi Liakhovetski
2012-05-09 15:37   ` Mark Brown
2012-05-09 15:09 ` [PATCH 7/9 v3] usb: renesas_usbhs: " Guennadi Liakhovetski
2012-05-09 23:59   ` kuninori.morimoto.gx
2012-05-10  0:07     ` Greg Kroah-Hartman
2012-05-09 15:09 ` [PATCH 8/9 v3] ASoC: fsi: " Guennadi Liakhovetski
2012-05-09 15:39   ` Mark Brown
2012-05-09 23:59   ` kuninori.morimoto.gx
2012-05-09 15:09 ` [PATCH 9/9 v3] dma: shdma: convert " Guennadi Liakhovetski
2012-07-25  3:59   ` Paul Mundt
2012-07-26  6:49     ` Vinod Koul
2012-07-26  6:58       ` Paul Mundt
2012-07-26 11:20         ` Vinod Koul
2012-07-26 21:39           ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1205251255310.13353@axis700.grange \
    --to=g.liakhovetski@gmx.de \
    --cc=ldewangan@nvidia.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=vinod.koul@linux.intel.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®