From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Chris Ball <cjb@laptop.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
LKML <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Boot regression on Mackerel with current mainline
Date: Tue, 10 Jul 2012 08:49:37 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1207100845130.29825@axis700.grange> (raw)
In-Reply-To: <87ipdws1mc.fsf@octavius.laptop.org>
Hi Chris
On Tue, 10 Jul 2012, Chris Ball wrote:
> Hi Guennadi,
>
> On Wed, Jul 04 2012, Guennadi Liakhovetski wrote:
> > On Tue, 3 Jul 2012, Rafael J. Wysocki wrote:
> >
> >> On Tuesday, July 03, 2012, Guennadi Liakhovetski wrote:
> >> > Hi Rafael
> >> >
> >> > On Tue, 3 Jul 2012, Rafael J. Wysocki wrote:
> >> >
> >> > > Hi,
> >> > >
> >> > > We seem to have a functional regression on Mackerel with 3.5-rc5 which
> >> > > seems to be related to SDHI. Namely, the SDHI driver appears to wait forever
> >> > > for the devices to appear and commenting out all of the sdhi devices in the
> >> > > board file works around the problem.
> >> > >
> >> > > I can investigate some more later today if need be.
> >> >
> >> > Have you checked the logs? Are you seeing any of these in the kernel log:
> >> >
> >> > genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq
> >>
> >> I see this only once per boot, but then sh_mobile_sdhi is saying "timeout
> >> waiting for hardware interrupt" pretty much continuously.
> >
> > Yes, that's the one. Ok, let's fix it in the driver. In fact, a fix has
> > already been submitted, but for 3.6. I hoped, 3.5 would resort to a softer
> > form of the ONESHOT failing, so, I didn't push it for -rc. I think, the
> > easiest would be to apply these two patches:
> >
> > "mmc: tmio: use MMC opcode defines instead of numbers"
> > http://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=commit;h=598cd9cc217b0aa46089a3838a8b1c37b97aa08b
> >
> > and
> >
> > "mmc: extend and rename cd-gpio helpers to handle more slot GPIO functions"
> > http://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=commit;h=d8e60fb51effc83e6f53de191a8440f46e5a3f2c
> >
> > The latter one looks big because of a rename, but with "-M" it's pretty
> > trivial. Chris, do you agree?
>
> Is the minimal fix to just add "| IRQF_ONESHOT" to the request_threaded_irq
> argument? If so, I'd rather push just that for 3.5, and I can take care of
> having that change appear simultaneously in linux-next so that there aren't
> any conflicts. Is that okay with you?
For that you'd have to rebase -next, right? you'd like to do that? Because
the patch
"mmc: extend and rename cd-gpio helpers to handle more slot GPIO functions"
http://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=commit;h=d8e60fb51effc83e6f53de191a8440f46e5a3f2c
obviously would conflict with adding "| IRQF_ONESHOT". Either would work
with me, sure. Would you like me to submit this trivial ONESHOT fix and an
updated version of the above patch, or would you prefer to do this
yourself?
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
next prev parent reply other threads:[~2012-07-10 6:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201207031218.24797.rjw@sisk.pl>
[not found] ` <Pine.LNX.4.64.1207031336320.29890@axis700.grange>
2012-07-03 17:10 ` Rafael J. Wysocki
2012-07-04 9:39 ` Guennadi Liakhovetski
2012-07-10 4:04 ` Chris Ball
2012-07-10 6:49 ` Guennadi Liakhovetski [this message]
2012-07-10 7:19 ` Chris Ball
2012-07-10 7:46 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1207100845130.29825@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®