From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>, Chris Ball <cjb@laptop.org>,
Kevin Liu <keyuan.liu@gmail.com>
Subject: Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value
Date: Tue, 12 Feb 2013 23:10:32 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.1302122309470.14434@axis700.grange> (raw)
In-Reply-To: <1360656096-1671-1-git-send-email-m.szyprowski@samsung.com>
Hi Marek
On Tue, 12 Feb 2013, Marek Szyprowski wrote:
> Some regulators don't report any voltage values, so checking supported
> voltage range results in disabling all SDHCI_CAN_VDD_* flags and
> registration failure. This patch finally provides a correct fix for the
> registration of SDHCI driver with all possible voltage regulators:
> dummy, fixed and regulated without using regulator_count_voltages()
> hacks.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/mmc/host/sdhci.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index ba586ae..735526b 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2976,7 +2976,11 @@ int sdhci_add_host(struct sdhci_host *host)
> }
>
> #ifdef CONFIG_REGULATOR
> - if (host->vmmc) {
> + /*
> + * Voltage range check makes sense only if regulator reports
> + * any voltage value.
> + */
> + if (host->vmmc && regulator_get_voltage(host->vmmc) > 0) {
> ret = regulator_is_supported_voltage(host->vmmc, 2700000,
> 3600000);
Wouldn't using mmc_regulator_get_ocrmask() be a better option?
Thanks
Guennadi
> if ((ret <= 0) || (!(caps[0] & SDHCI_CAN_VDD_330)))
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
next prev parent reply other threads:[~2013-02-12 22:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 14:01 [PATCH v2 0/3] Fix fixed regulators support Marek Szyprowski
2012-12-04 14:01 ` [PATCH 1/3] regulators: add regulator_can_change_voltage() function Marek Szyprowski
2012-12-06 6:18 ` Mark Brown
2012-12-04 14:01 ` [PATCH 2/3] mmc: use regulator_can_change_voltage() instead of regulator_count_voltages() hacks Marek Szyprowski
2013-02-01 14:39 ` Marek Szyprowski
2013-02-11 17:26 ` Chris Ball
2012-12-04 14:01 ` [PATCH 3/3] mmc: sdhci: check voltage range only on regulators aware of voltage value Marek Szyprowski
2012-12-04 14:50 ` Kevin Liu
2012-12-05 1:48 ` Mark Brown
2012-12-05 2:12 ` Kevin Liu
2013-02-01 14:40 ` Marek Szyprowski
2013-02-11 17:27 ` Chris Ball
2013-02-12 8:01 ` [PATCH 3/3 RESEND] " Marek Szyprowski
2013-02-12 22:10 ` Guennadi Liakhovetski [this message]
2013-02-13 7:33 ` Marek Szyprowski
2013-02-13 7:45 ` Guennadi Liakhovetski
2013-02-13 11:35 ` Mark Brown
2013-02-14 8:05 ` Marek Szyprowski
2013-02-14 11:03 ` Mark Brown
2013-02-14 11:08 ` Ulf Hansson
2013-02-20 9:34 ` Kevin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1302122309470.14434@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=keyuan.liu@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®