From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757344Ab3BYHta (ORCPT ); Mon, 25 Feb 2013 02:49:30 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:63699 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754895Ab3BYHt2 (ORCPT ); Mon, 25 Feb 2013 02:49:28 -0500 Date: Mon, 25 Feb 2013 08:49:26 +0100 (CET) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Dmitry Torokhov cc: Mauro Carvalho Chehab , Sakari Ailus , Timo Kokkonen , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Media: remove incorrect __exit markups In-Reply-To: <20130225032215.GA9352@core.coreip.homeip.net> Message-ID: References: <20130225032215.GA9352@core.coreip.homeip.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Provags-ID: V02:K0:mryrH5GYi4be58JdsfcAw49g9rO+RPElWvPwZe4qJPj VkUb4QphDeKqmr+Fx70fgVQIlroxRsxCO6/nZJYPcBhawcwNJp 9KroxskMkU0I2rq8hxg9aEPh06WIU4BsLIZBxI+JdN4Y4CNpOo PC7HUJm0hFDWSbKav7CqixUrJmJeStgafbGy9hlCArfNlDFOTW 4MIOyOgfAsMsOCBpLmAASYW8M3FGgC/X66kL4lOaKQ+7J7Q8Nr YI0hvtdVIM/cuIZgCrb3Iu/7UXr0zZurRs+F3iHgJAglRxYm4z ND3As/2YNsI4bQSLqKVowgD0ZI/PpthTCnNl+5bcxQRyw9o+tN UU0+v2Uh4xfRUo+YPLtTU+4tqRBGZOmGx9mzDSB+QBFmnqQOsp 83CzMkkz6hUvg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry On Sun, 24 Feb 2013, Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, the devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() which specifically disables sysfs bind/unbind > attributes. > > Signed-off-by: Dmitry Torokhov > --- > drivers/media/i2c/adp1653.c | 4 ++-- > drivers/media/i2c/smiapp/smiapp-core.c | 4 ++-- > drivers/media/platform/soc_camera/omap1_camera.c | 4 ++-- > drivers/media/radio/radio-si4713.c | 4 ++-- > drivers/media/rc/ir-rx51.c | 4 ++-- > 5 files changed, 10 insertions(+), 10 deletions(-) [snip] > diff --git a/drivers/media/platform/soc_camera/omap1_camera.c b/drivers/media/platform/soc_camera/omap1_camera.c > index 39a77f0..5f548ac 100644 > --- a/drivers/media/platform/soc_camera/omap1_camera.c > +++ b/drivers/media/platform/soc_camera/omap1_camera.c > @@ -1677,7 +1677,7 @@ exit: > return err; > } > > -static int __exit omap1_cam_remove(struct platform_device *pdev) > +static int omap1_cam_remove(struct platform_device *pdev) > { > struct soc_camera_host *soc_host = to_soc_camera_host(&pdev->dev); > struct omap1_cam_dev *pcdev = container_of(soc_host, > @@ -1709,7 +1709,7 @@ static struct platform_driver omap1_cam_driver = { > .name = DRIVER_NAME, > }, > .probe = omap1_cam_probe, > - .remove = __exit_p(omap1_cam_remove), > + .remove = omap1_cam_remove, > }; > > module_platform_driver(omap1_cam_driver); This looks correct, but don't we also have to remove __init from omap1_cam_probe()? Or would that be a separate patch? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/