mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial: fix some then vs. than typos
Date: Thu, 25 Apr 2013 16:26:41 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.1304251623210.21045@axis700.grange> (raw)
In-Reply-To: <alpine.LNX.2.00.1304251615020.29143@pobox.suse.cz>

Hi Jiri

On Thu, 25 Apr 2013, Jiri Kosina wrote:

> On Wed, 17 Apr 2013, Guennadi Liakhovetski wrote:
> 
> > This patch fixes some of the obvious then vs. than typos.
> > 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> [ ... snip ... ]
> > --- a/Documentation/usb/mass-storage.txt
> > +++ b/Documentation/usb/mass-storage.txt
> > @@ -121,7 +121,7 @@
> >      capped.
> >  
> >      If this parameter is provided, and the number of files specified
> > -    in â??fileâ?? argument is greater then the value of â??lunsâ??, all excess
> > +    in â??fileâ?? argument is greater than the value of â??lunsâ??, all excess
> 
> UTF8 encoding problem?

Yep, looks like that.

> > --- a/arch/blackfin/lib/udivsi3.S
> > +++ b/arch/blackfin/lib/udivsi3.S
> > @@ -66,7 +66,7 @@ ENTRY(___udivsi3)
> >  .Ly_16bit:
> >    /* We know that the upper 17 bits of Y might have bits set,
> >    ** or that the sign bit of X might have a bit. If Y is a
> > -  ** 16-bit number, but not bigger, then we can use the builtins
> > +  ** 16-bit number, but not bigger, than we can use the builtins
> 
> This change is wrong.

Indeed :) As I said, my grepping did return a few false-positives, I 
cleaned up most of them, but missed this one.

Anyway, the patch was incomplete, and perhaps it would be better to split 
it into a series of patches - one per top-level directory to reduce merge 
conflicts. So, maybe someone with better UTF8 and grep / English grammar 
skills could take this over, I won't be requiring any credit for this :)

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

      reply	other threads:[~2013-04-25 14:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-17  9:04 Guennadi Liakhovetski
2013-04-25 14:16 ` Jiri Kosina
2013-04-25 14:26   ` Guennadi Liakhovetski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1304251623210.21045@axis700.grange \
    --to=g.liakhovetski@gmx.de \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®