From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Tony Lindgren <tony@atomide.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH/RFC 0/4] dmaengine: add DT support for DMA multiplexers
Date: Thu, 2 May 2013 22:46:17 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1305022157580.23970@axis700.grange> (raw)
In-Reply-To: <20130502162837.GM1960@intel.com>
On Thu, 2 May 2013, Vinod Koul wrote:
> On Tue, Apr 30, 2013 at 02:17:13PM +0200, Guennadi Liakhovetski wrote:
> > (added Russell to CC, sorry for not including initially)
> >
> > Hi Vinod
> >
> > On Tue, 30 Apr 2013, Vinod Koul wrote:
> >
> > > On Tue, Apr 30, 2013 at 09:11:19AM +0200, Guennadi Liakhovetski wrote:
> > > > Previously an issue has been discussed, arising on sh-/r-mobile ARM-based
> > > > systems. There we typically have multiple DMA controller instances with
> > > > exactly equal or very similar capabilities. Each of them can serve the same
> > > > slaves, using the same slave identifiers (request line IDs). With the
> > > > present DMA DT implementation _each_ such DMA slave would have to reference
> > > > _each_ of those DMA controllers in its DMA bindings, e.g.
> > > But why... if that is the case then we havent define DT-bindings clearly enough
> >
> > Sorry, what do you mean "why?" Why each slave has to reference each DMA
> > controller? We have discussed this A LOT before... My understanding is,
> > that we decided, that the sh-/r-mobile case of multiple equal DMA
> > controllers is an exception and that we don't want to punish everyone for
> > it. So, the design includes only explicit requesting of specific DMA
> > request lines on specific DMA controllers, no wild-cards. If a slave DMA
> > channel can be provided by several DMA controllers we decided to list them
> > all explicitly too. And for the sh-/r-mobile case a DMA-mux DT node has
> > been proposed. This is exactly what this patch series is implementing. Is
> > my understanding wrong?
> >
> > > And we havent merged that yet, so why not fix that in first set itself
> >
> > Sorry, don't understand. The series isn't merged yet, that's right. That's
> > why I explicitly mention this dependency here. But this isn't a fix. This
> > is a new feature. The first patch-series only touches a specific DMA
> > controller driver and relevant platforms. No core changes, so, it's not
> > that intrusive and can be applied quickly. Whereas this series affects the
> > core and might need a more careful consideration, discussion, etc.
> What i mean from above is if we were already defining the sh-DT binding then why
> wasnt this taken care in the orignal definition?
>
> It would make sense to have proper binding which works well for both of these
> case, why a two shot approach?
In the first patch-series we implement DT support in shdma according to
the existing API and add DT nodes to a platform. This is already a
functioning implementation. The second patch-set is a new feature. It adds
a new API - a DMA multiplexer and implementation examples. This way we can
clearly show how the new API shall be used - what _changes_ are required
to existing DMA DT implementations to support it. I think it makes sense
to do this in two steps.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
prev parent reply other threads:[~2013-05-02 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 7:11 Guennadi Liakhovetski
2013-04-30 7:11 ` [PATCH 1/4] OF: add a new phandle parsing function for grouped nodes Guennadi Liakhovetski
2013-04-30 7:11 ` [PATCH 2/4] dmaengine: add support for DMA multiplexer DT nodes Guennadi Liakhovetski
2013-04-30 7:11 ` [PATCH 3/4] ARM: shmobile: move r8a7740 DMA controller DT node under a "dma-mux" node Guennadi Liakhovetski
2013-04-30 7:11 ` [PATCH 4/4] OF: modify function stubs to match proper function declarations Guennadi Liakhovetski
2013-06-06 6:54 ` Guennadi Liakhovetski
2013-04-30 10:43 ` [PATCH/RFC 0/4] dmaengine: add DT support for DMA multiplexers Vinod Koul
2013-04-30 12:17 ` Guennadi Liakhovetski
2013-05-02 16:28 ` Vinod Koul
2013-05-02 20:46 ` Guennadi Liakhovetski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1305022157580.23970@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®