mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Felipe Ferreri Tonello <eu@felipetonello.com>
Cc: linux-mmc@vger.kernel.org, ben-linux@fluff.org, cjb@laptop.org,
	arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mmc: sdhci: Added set_power sdhci_ops handler.
Date: Thu, 23 May 2013 09:25:16 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.1305230920430.23354@axis700.grange> (raw)
In-Reply-To: <2537252.KzShHU8h54@localhost.localdomain>

On Wed, 22 May 2013, Felipe Ferreri Tonello wrote:

> Hi Guennadi,
> 
> On Wednesday, May 22, 2013 10:30:40 PM Guennadi Liakhovetski wrote:
> > On Wed, 22 May 2013, Felipe F. Tonello wrote:
> > > From: "Felipe F. Tonello" <eu@felipetonello.com>
> > > 
> > > This is useful for power managment purposes if a sdhci child host wants to
> > > turn off some other peripheral also.
> > 
> > Sorry, could you elaborate a bit? In what situations is it exactly useful?
> > And why cannot the regulator API be used there?
> 
> Sorry about that.
> 
> One example that I can think of is when you have a wifi module connected as a 
> mmc card via sdio. So you can register a callback function in your machine 
> source code to turn on/off the wifi module based on the mmc host power.

Ok, understand. Your second patch in this series adds such a callback in 
your SDHCI host driver and there it just calls a platform callback. I 
don't think this is a good idea. First, we want to go away from platform 
callbacks, because they are incompatible with DT. Second, because the 
proper solution IMHO would be for your platform to export a regulator, and 
the SDHCI core driver already includes regulator support.

> I've seen this implementation in others mmc hosts, such as omap.

Which, however, doesn't yet mean, it's a good idea :)

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

  reply	other threads:[~2013-05-23  7:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22 17:47 [PATCH 0/2] Added set_power handler to mmc sdhci host Felipe F. Tonello
2013-05-22 17:47 ` [PATCH 1/2] mmc: sdhci: Added set_power sdhci_ops handler Felipe F. Tonello
2013-05-22 20:30   ` Guennadi Liakhovetski
2013-05-22 21:22     ` Felipe Ferreri Tonello
2013-05-23  7:25       ` Guennadi Liakhovetski [this message]
2013-05-24  4:02         ` Jaehoon Chung
2013-05-24 22:12           ` Felipe Tonello
2013-05-22 17:47 ` [PATCH 2/2] mmc: sdhci-s3c: Added set_power handler to platdata Felipe F. Tonello
2013-05-24  3:57   ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1305230920430.23354@axis700.grange \
    --to=g.liakhovetski@gmx.de \
    --cc=arnd@arndb.de \
    --cc=ben-linux@fluff.org \
    --cc=cjb@laptop.org \
    --cc=eu@felipetonello.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®