From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>
Subject: [PATCH] regulator: da9210: add Device Tree binding documentation
Date: Thu, 12 Sep 2013 12:57:20 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1309121254330.4632@axis700.grange> (raw)
In-Reply-To: <20130909160406.GS29403@sirena.org.uk>
DA9210 Device Tree support currently only handles standard regulator DT
bindings. This patch adds compulsory minimal documentation to describe
this.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
---
On Mon, 9 Sep 2013, Mark Brown wrote:
> On Mon, Sep 09, 2013 at 05:52:00PM +0200, Guennadi Liakhovetski wrote:
> > This patch adds basic Device Tree support to the da9210 regulator driver -
> > with no special properties, since also driver's platform data only contains
> > standard regulator initialisation parameters.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > ---
> > drivers/regulator/da9210-regulator.c | 9 ++++++---
>
> I'd expect to see a binding document, even if it is just a very brief
> one documenting the prefix and pointing to the standard regulator
> properties.
Hi Mark,
Is a separate patch like this one ok or you'd prefer me to re-post the
original series and merge this with the DT implementation?
.../devicetree/bindings/regulator/da9210.txt | 21 ++++++++++++++++++++
1 files changed, 21 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/da9210.txt
diff --git a/Documentation/devicetree/bindings/regulator/da9210.txt b/Documentation/devicetree/bindings/regulator/da9210.txt
new file mode 100644
index 0000000..f120f22
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/da9210.txt
@@ -0,0 +1,21 @@
+* Dialog Semiconductor DA9210 Voltage Regulator
+
+Required properties:
+
+- compatible: must be "diasemi,da9210"
+- reg: the i2c slave address of the regulator. It should be 0x68.
+
+Any standard regulator properties can be used to configure the single da9210
+DCDC.
+
+Example:
+
+ da9210@68 {
+ compatible = "diasemi,da9210";
+ reg = <0x68>;
+
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
--
1.7.2.5
next prev parent reply other threads:[~2013-09-12 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 15:51 [PATCH 0/2] regulator: da9210: support Device Tree initialisation Guennadi Liakhovetski
2013-09-09 15:51 ` [PATCH 1/2] DT: add a vendor prefix for Dialog Semiconductor Guennadi Liakhovetski
2013-09-09 15:52 ` [PATCH 2/2] regulator: da9210: add Device Tree support Guennadi Liakhovetski
2013-09-09 16:04 ` Mark Brown
2013-09-12 10:57 ` Guennadi Liakhovetski [this message]
2013-09-12 11:17 ` [PATCH] regulator: da9210: add Device Tree binding documentation Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1309121254330.4632@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®