From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-kernel@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH v2 5/5] ARM: shmobile: lager: (DEVEL) add CPUFreq support
Date: Fri, 27 Sep 2013 10:37:37 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1309271033270.23205@axis700.grange> (raw)
In-Reply-To: <52447B9A.5090805@cogentembedded.com>
Hi Sergei
On Thu, 26 Sep 2013, Sergei Shtylyov wrote:
> Hello.
>
> On 09/26/2013 09:21 PM, Guennadi Liakhovetski wrote:
>
> > The Lager board uses a DA9210 voltage regulator to supply DVFS power to the
> > CA15 cores on the r8a7790 SoC. This patch adds CPUFreq support for that
> > board using the cpufreq-cpu0 driver.
>
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > ---
>
> > v2: added 'status = "okay";' to the i2c bus
>
> > arch/arm/boot/dts/r8a7790-lager-reference.dts | 33
> > ++++++++++++++++++++++++
> > arch/arm/mach-shmobile/board-lager-reference.c | 4 ++-
> > 2 files changed, 36 insertions(+), 1 deletions(-)
>
> > diff --git a/arch/arm/boot/dts/r8a7790-lager-reference.dts
> > b/arch/arm/boot/dts/r8a7790-lager-reference.dts
> > index c462ef1..1ce0a97 100644
> > --- a/arch/arm/boot/dts/r8a7790-lager-reference.dts
> > +++ b/arch/arm/boot/dts/r8a7790-lager-reference.dts
> > @@ -43,3 +43,36 @@
> > };
> > };
> > };
> > +
> > +&i2c3 {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c3_pins>;
> > +
> > + vdd_dvfs: da9210@68 {
>
> ePAPR spec [1] says: "The name of a node should be somewhat generic,
> reflecting the function of the device and not its precise programming model."
Sure, but I think it is common in Linux .dts files for I2C devices to use
"<model>@<i2c addr>" as a name.
> So I suggest "regulator" instead of "da9210".
>
> > + compatible = "diasemi,da9210";
> > + reg = <0x68>;
> > +
> > + regulator-min-microvolt = <900000>;
> > + regulator-max-microvolt = <1000000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +};
> [...]
> > diff --git a/arch/arm/mach-shmobile/board-lager-reference.c
> > b/arch/arm/mach-shmobile/board-lager-reference.c
> > index 1a1a4a8..2bc8bae 100644
> > --- a/arch/arm/mach-shmobile/board-lager-reference.c
> > +++ b/arch/arm/mach-shmobile/board-lager-reference.c
> [...]
> > @@ -29,7 +30,8 @@ static void __init lager_add_standard_devices(void)
> > r8a7790_clock_init();
> >
> > r8a7790_add_dt_devices();
> > - of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> > + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
>
> Hm, "drove-by" cleanup?
This should be avoided in general, but this kind of stuff really doesn't
deserve neither a separate patch nor a mention. Don't waste your precious
brain cycles.
> > + platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
> > }
> >
> > static const char *lager_boards_compat_dt[] __initdata = {
>
> Shouldn't the patch be split into .dts and .c parts, I wonder?
Simon didn't complain, but perhaps it should, yes. I think I'll resubmit
this as 2 patches with no changes.
Thanks
Guennadi
> [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
>
> WBR, Sergei
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
next prev parent reply other threads:[~2013-09-27 8:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 17:20 [PATCH v2 0/5] ARM: shmobile: CPUFreq support on Lager Guennadi Liakhovetski
2013-09-26 17:20 ` [PATCH v2 1/5] pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface Guennadi Liakhovetski
2013-09-27 0:09 ` Laurent Pinchart
2013-09-26 17:20 ` [PATCH v2 2/5] ARM: shmobile: r8a7790: add I2C clocks and aliases for the DT mode Guennadi Liakhovetski
2013-09-27 4:49 ` Simon Horman
2013-09-26 17:20 ` [PATCH v2 3/5] ARM: shmobile: r8a7790: add I2C DT nodes Guennadi Liakhovetski
2013-09-27 4:48 ` Simon Horman
2013-09-26 17:20 ` [PATCH v2 4/5] ARM: shmobile: r8a7790: add CPUFreq clock support Guennadi Liakhovetski
2013-09-26 17:21 ` [PATCH v2 5/5] ARM: shmobile: lager: (DEVEL) add CPUFreq support Guennadi Liakhovetski
2013-09-26 18:23 ` Sergei Shtylyov
2013-09-27 8:37 ` Guennadi Liakhovetski [this message]
2013-09-26 23:59 ` Laurent Pinchart
2013-09-27 6:32 ` Guennadi Liakhovetski
2013-09-30 15:25 ` [PATCH v2 0/5] ARM: shmobile: CPUFreq support on Lager Guennadi Liakhovetski
2013-09-30 23:53 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1309271033270.23205@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®