From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Suman Kumar <suman@inforcecomputing.com>
Cc: m.chehab@samsung.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: soc_camera: soc_camera_platform.c: Fixed a Missing blank line coding style issue
Date: Sat, 9 Aug 2014 19:36:14 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1408091934100.20541@axis700.grange> (raw)
In-Reply-To: <1407604952-15492-1-git-send-email-suman@inforcecomputing.com>
Hi Suman,
On Sat, 9 Aug 2014, Suman Kumar wrote:
> Fixes a coding style issue reported by checkpatch.pl
Thanks for your patch. To my taste checkpatch.pl has unfortunately become
too noisy with meaningless / unimportant warnings like this one. Is this
in CodingStyle? If not, my intention is to drop this. However, Mauro may
override by either taking this himself or asking me to apply this.
Thanks
Guennadi
>
> Signed-off-by: Suman Kumar <suman@inforcecomputing.com>
> ---
> drivers/media/platform/soc_camera/soc_camera_platform.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/soc_camera/soc_camera_platform.c b/drivers/media/platform/soc_camera/soc_camera_platform.c
> index ceaddfb..fe15a80 100644
> --- a/drivers/media/platform/soc_camera/soc_camera_platform.c
> +++ b/drivers/media/platform/soc_camera/soc_camera_platform.c
> @@ -27,12 +27,14 @@ struct soc_camera_platform_priv {
> static struct soc_camera_platform_priv *get_priv(struct platform_device *pdev)
> {
> struct v4l2_subdev *subdev = platform_get_drvdata(pdev);
> +
> return container_of(subdev, struct soc_camera_platform_priv, subdev);
> }
>
> static int soc_camera_platform_s_stream(struct v4l2_subdev *sd, int enable)
> {
> struct soc_camera_platform_info *p = v4l2_get_subdevdata(sd);
> +
> return p->set_capture(p, enable);
> }
>
> --
> 1.8.2
>
next prev parent reply other threads:[~2014-08-09 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 17:22 Suman Kumar
2014-08-09 17:36 ` Guennadi Liakhovetski [this message]
2014-08-09 17:47 ` Hans Verkuil
-- strict thread matches above, loose matches on Subject: below --
2014-08-09 17:10 Suman Kumar
2014-08-09 16:40 Suman Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1408091934100.20541@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=suman@inforcecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®