From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235AbbIPPIU (ORCPT ); Wed, 16 Sep 2015 11:08:20 -0400 Received: from mout.gmx.net ([212.227.15.19]:52930 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbbIPPIS (ORCPT ); Wed, 16 Sep 2015 11:08:18 -0400 Date: Wed, 16 Sep 2015 17:08:06 +0200 (CEST) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Wang YanQing cc: mchehab@osg.samsung.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [media] soc_camera: soc_camera_pdrv_probe: fix potential NULL pointer dereference In-Reply-To: <20150916150003.GA2195@udknight> Message-ID: References: <20150916150003.GA2195@udknight> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Provags-ID: V03:K0:y9z82fEBMOBEV7/0u30yM6UoTO053MuMs71g+5bS/Up8Iy6EpBe yTD6nRG7yNs/erohJbF4izXCOargoflJ8YwhPrvSKiADvuALAw57W1fqIjXvE8eBbHGaJ5/ 1gpRU9onB3VaVsbHTXgmgAJCj5AO+fUexLcFsDO9K9v602nij8yWCZ/UZ7mETPu6eI9BdJ/ LEi/RsOpBRaDkseHkzr+A== X-UI-Out-Filterresults: notjunk:1;V01:K0:pYWzrdXZ8ag=:4qgaYh5h9KltRuWWF+PhQD mYrs19UF2ZADp3BiEQHSgwA/KKXUAHtK34TNB2jcWtTa+/rpSkRuXFgTHRh2/WzOp76+DF8/m vVnKrZ2XDxy4xeuEcWHzwr+GiJHJ4+vWP9Fytp2EwbkKnXzP4/cCAKurXLtIODqS13N8BJPVZ jHeR5pE/j7ricMqopdw/JK4WGn1Zbzy60GjZCExAZLoCU6gfSSJ5ohUFDj5dnL9nw2hLEAcJA IHsrluoKIbjYiDI358B8dFI4raXwpd5dzbHVL4EIVxjRcNe1xbZfYU8o6BHEbln2jaAnvC8rG cdgETfCy9Xu+N23ETQhzSY268SUtBi1izi2tBCPCcRiAi/iQkAtcfKa423sCL1YhBl2G+sc8l 3izS3c3RoiyBBa8wK2yYG7pT/6YgRbklmcHYJUmxVhD6UZJFrr+y9ezh+lW484w1QnpFUsfeJ mUNvERPyIkaIu+l/ThnlGoCqOnit69WdIX6a6IDyFSMmjdzwe3fy0REmcVoNO0/L6hB/QNOvE f9tuyXoStG2GOnfwNMnq0mECz9wwDSnUJYzD9ypYz1MNczkjANjUEgNZWBZ3p3/rFYvWoKt05 Xe0yC7JQwmxNfr8lPzCP2FWvkISFkD0x9KExyuI88oqRbXuLVMTibXhYyuI+HMvfcECkEjFMK 4qIg681XlFd4uNe9KjECvNJLMW+Ic1i1n3j0nI0rsZodVJqSnzNpW8BeMuyyGvuK90u4Kw0PC tphg0Asy26tQUMgoLYWgKz49M6ig1GmQEu/dKg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Sep 2015, Wang YanQing wrote: > Move dereference of sdesc after NULL pointer checker. > > Signed-off-by: Wang YanQing > --- > drivers/media/platform/soc_camera/soc_camera.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_camera.c > index 9087fed..53b153d 100644 > --- a/drivers/media/platform/soc_camera/soc_camera.c > +++ b/drivers/media/platform/soc_camera/soc_camera.c > @@ -2187,13 +2187,14 @@ static int soc_camera_video_start(struct soc_camera_device *icd) > static int soc_camera_pdrv_probe(struct platform_device *pdev) > { > struct soc_camera_desc *sdesc = pdev->dev.platform_data; > - struct soc_camera_subdev_desc *ssdd = &sdesc->subdev_desc; > + struct soc_camera_subdev_desc *ssdd; NAK. This isn't a dereference. This is just an address calculation. Thanks Guennadi > struct soc_camera_device *icd; > int ret; > > if (!sdesc) > return -EINVAL; > > + ssdd = &sdesc->subdev_desc; > icd = devm_kzalloc(&pdev->dev, sizeof(*icd), GFP_KERNEL); > if (!icd) > return -ENOMEM; > -- > 1.8.5.6.2.g3d8a54e.dirty >