From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Jiri Kosina <trivial@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] media: pxa_camera: trivial move of dma irq functions
Date: Sun, 21 Feb 2016 13:58:36 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.1602211356070.5959@axis700.grange> (raw)
In-Reply-To: <1441539733-19201-3-git-send-email-robert.jarzmik@free.fr>
Hi Robert,
On Sun, 6 Sep 2015, Robert Jarzmik wrote:
> This moves the dma irq handling functions up in the source file, so that
> they are available before DMA preparation functions. It prepares the
> conversion to DMA engine, where the descriptors are populated with these
> functions as callbacks.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Since v1: fixed prototypes change
> Since v4: refixed prototypes change
> ---
> drivers/media/platform/soc_camera/pxa_camera.c | 42 +++++++++++++++-----------
> 1 file changed, 24 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media/platform/soc_camera/pxa_camera.c
> index db041a5ed444..bb7054221a86 100644
> --- a/drivers/media/platform/soc_camera/pxa_camera.c
> +++ b/drivers/media/platform/soc_camera/pxa_camera.c
> @@ -311,6 +311,30 @@ static int calculate_dma_sglen(struct scatterlist *sglist, int sglen,
> return i + 1;
> }
>
> +static void pxa_camera_dma_irq(struct pxa_camera_dev *pcdev,
> + enum pxa_camera_active_dma act_dma);
This is v5. You fixed prototypes in v1 and v4. Let's see:
> +
> +static void pxa_camera_dma_irq_y(int channel, void *data)
> +{
> + struct pxa_camera_dev *pcdev = data;
> +
> + pxa_camera_dma_irq(channel, pcdev, DMA_Y);
This doesn't seem fixed to me.
Thanks
Guennadi
> +}
> +
> +static void pxa_camera_dma_irq_u(int channel, void *data)
> +{
> + struct pxa_camera_dev *pcdev = data;
> +
> + pxa_camera_dma_irq(channel, pcdev, DMA_U);
> +}
> +
> +static void pxa_camera_dma_irq_v(int channel, void *data)
> +{
> + struct pxa_camera_dev *pcdev = data;
> +
> + pxa_camera_dma_irq(channel, pcdev, DMA_V);
> +}
> +
> /**
> * pxa_init_dma_channel - init dma descriptors
> * @pcdev: pxa camera device
> @@ -802,24 +826,6 @@ out:
> spin_unlock_irqrestore(&pcdev->lock, flags);
> }
>
> -static void pxa_camera_dma_irq_y(int channel, void *data)
> -{
> - struct pxa_camera_dev *pcdev = data;
> - pxa_camera_dma_irq(channel, pcdev, DMA_Y);
> -}
> -
> -static void pxa_camera_dma_irq_u(int channel, void *data)
> -{
> - struct pxa_camera_dev *pcdev = data;
> - pxa_camera_dma_irq(channel, pcdev, DMA_U);
> -}
> -
> -static void pxa_camera_dma_irq_v(int channel, void *data)
> -{
> - struct pxa_camera_dev *pcdev = data;
> - pxa_camera_dma_irq(channel, pcdev, DMA_V);
> -}
> -
> static struct videobuf_queue_ops pxa_videobuf_ops = {
> .buf_setup = pxa_videobuf_setup,
> .buf_prepare = pxa_videobuf_prepare,
> --
> 2.1.4
>
next prev parent reply other threads:[~2016-02-21 19:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 11:42 [PATCH v5 1/4] media: pxa_camera: fix the buffer free path Robert Jarzmik
2015-09-06 11:42 ` [PATCH v5 2/4] media: pxa_camera: move interrupt to tasklet Robert Jarzmik
2015-09-06 11:42 ` [PATCH v5 3/4] media: pxa_camera: trivial move of dma irq functions Robert Jarzmik
2016-02-21 12:58 ` Guennadi Liakhovetski [this message]
2016-02-21 13:10 ` Guennadi Liakhovetski
2015-09-06 11:42 ` [PATCH v5 4/4] media: pxa_camera: conversion to dmaengine Robert Jarzmik
2015-10-24 9:59 ` [PATCH v5 1/4] media: pxa_camera: fix the buffer free path Robert Jarzmik
2015-10-27 22:07 ` Guennadi Liakhovetski
2015-10-27 22:15 ` Robert Jarzmik
2015-10-29 16:01 ` Guennadi Liakhovetski
2016-02-08 20:25 ` Robert Jarzmik
2016-02-21 13:01 ` Guennadi Liakhovetski
2016-02-21 14:53 ` Robert Jarzmik
2016-02-21 16:50 ` Guennadi Liakhovetski
2016-02-22 21:22 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1602211356070.5959@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=robert.jarzmik@free.fr \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®