From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752821AbcBURXF (ORCPT ); Sun, 21 Feb 2016 12:23:05 -0500 Received: from mout.gmx.net ([212.227.15.15]:53683 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752737AbcBURW7 (ORCPT ); Sun, 21 Feb 2016 12:22:59 -0500 Date: Sun, 21 Feb 2016 14:10:26 +0100 (CET) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Robert Jarzmik cc: Mauro Carvalho Chehab , Jiri Kosina , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/4] media: pxa_camera: trivial move of dma irq functions In-Reply-To: Message-ID: References: <1441539733-19201-1-git-send-email-robert.jarzmik@free.fr> <1441539733-19201-3-git-send-email-robert.jarzmik@free.fr> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Provags-ID: V03:K0:wLTcLpUdcPMJSfDkxX3V+NOHiArri1NWjZjbNV7hrwLhF9tiWLV j1YgZIR161XSWxvpUKjhFdJkMGwuoVeOOQYa7mTJVjehrak6bDdJpmDkwqPfSUumd/2I6A5 cnOf9dcrdYqYTqYotqxe9lu5DrGFp7BUxDbwO5UliEdau16LqOaf6g+RZIE2wrtSGf3GdUu jyBHmyOGkZVH8lxeUQe/w== X-UI-Out-Filterresults: notjunk:1;V01:K0:TyNrC5Ocw0o=:GeEQJOYOqWnmsbGQ5fy3bT ac16p7CuHuqz8t++MvkoOdHKjvrsmkZCP4ejh6IrHX6Bt6vIrKCPu5DXVqbLa7xSTUFbiz70v C2vUwsxw6o6NJSf3fqM6XaplAG8Ghxl6k5EYg+QbJSdciFIgixvkRjBbdDdUuFGt5bCLxaq62 JZFb58WUqd6EIO7ev6ZP946KWRBGi+/w+dObYUL/+hSTUzlPp3WXhrw9ypNwkycQzv4Y9nl6d LzgXdmeVffRUoMtNinxklNr68fa17KnljbhryiZPZJpgJuKSm8w1vV6oTn4q9ZfdPwGMNvqqg o7+s1U2kVJN454IMe1n8JCtrLhlUmNtuaz+RFsATWgdxGGkrkTVaY2PWQBBxheSu1l8yLW9dL 7g65quEIaGfD5SUVwl12QxDxn+I1DUw93aPKPnKzhGHdOvDgyA1bG9jAMKstgM0k8/pjE2ZSe XC71VwqQjL9I1jkuOXZ4kKMQtBDt8ZrJLnmVNiF596rWMlTjj2IBptiDcue2y8aX0YW6+hVFR ozvWYmDK7gi8BWsV1eOw7EtL8ns4nvT7rLtHBPdnQceMKg3+RM6k8yzbxs0G23jRcbmekdV3c E61Ts3+z58csguKlS0D8yaex2KXjfjQH9PtIpER7REoayFmR/61C3uNyfWqnpejXeimUYMokl gg4suONBZ/7YBPWIiJ3hYOHSZ+zbXVB+apnqUoGcyePgL45mf4IxJcILtPE2pP676YtRI09t6 c39lk2+xH+WJd6g9OsQtVamfQD7OZy2jiM+xkXAI1KLeejby2DgvJRPFO6DrwfAhAmZ8OeFHp Y3hC6AJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 Feb 2016, Guennadi Liakhovetski wrote: > Hi Robert, > > On Sun, 6 Sep 2015, Robert Jarzmik wrote: > > > This moves the dma irq handling functions up in the source file, so that > > they are available before DMA preparation functions. It prepares the > > conversion to DMA engine, where the descriptors are populated with these > > functions as callbacks. > > > > Signed-off-by: Robert Jarzmik > > --- > > Since v1: fixed prototypes change > > Since v4: refixed prototypes change > > --- > > drivers/media/platform/soc_camera/pxa_camera.c | 42 +++++++++++++++----------- > > 1 file changed, 24 insertions(+), 18 deletions(-) > > > > diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media/platform/soc_camera/pxa_camera.c > > index db041a5ed444..bb7054221a86 100644 > > --- a/drivers/media/platform/soc_camera/pxa_camera.c > > +++ b/drivers/media/platform/soc_camera/pxa_camera.c > > @@ -311,6 +311,30 @@ static int calculate_dma_sglen(struct scatterlist *sglist, int sglen, > > return i + 1; > > } > > > > +static void pxa_camera_dma_irq(struct pxa_camera_dev *pcdev, > > + enum pxa_camera_active_dma act_dma); > > This is v5. You fixed prototypes in v1 and v4. Let's see: > > > + > > +static void pxa_camera_dma_irq_y(int channel, void *data) > > +{ > > + struct pxa_camera_dev *pcdev = data; > > + > > + pxa_camera_dma_irq(channel, pcdev, DMA_Y); > > This doesn't seem fixed to me. Forget about this, I'll fix it locally. > > Thanks > Guennadi > > > +} > > + > > +static void pxa_camera_dma_irq_u(int channel, void *data) > > +{ > > + struct pxa_camera_dev *pcdev = data; > > + > > + pxa_camera_dma_irq(channel, pcdev, DMA_U); > > +} > > + > > +static void pxa_camera_dma_irq_v(int channel, void *data) > > +{ > > + struct pxa_camera_dev *pcdev = data; > > + > > + pxa_camera_dma_irq(channel, pcdev, DMA_V); > > +} > > + > > /** > > * pxa_init_dma_channel - init dma descriptors > > * @pcdev: pxa camera device > > @@ -802,24 +826,6 @@ out: > > spin_unlock_irqrestore(&pcdev->lock, flags); > > } > > > > -static void pxa_camera_dma_irq_y(int channel, void *data) > > -{ > > - struct pxa_camera_dev *pcdev = data; > > - pxa_camera_dma_irq(channel, pcdev, DMA_Y); > > -} > > - > > -static void pxa_camera_dma_irq_u(int channel, void *data) > > -{ > > - struct pxa_camera_dev *pcdev = data; > > - pxa_camera_dma_irq(channel, pcdev, DMA_U); > > -} > > - > > -static void pxa_camera_dma_irq_v(int channel, void *data) > > -{ > > - struct pxa_camera_dev *pcdev = data; > > - pxa_camera_dma_irq(channel, pcdev, DMA_V); > > -} > > - > > static struct videobuf_queue_ops pxa_videobuf_ops = { > > .buf_setup = pxa_videobuf_setup, > > .buf_prepare = pxa_videobuf_prepare, > > -- > > 2.1.4 > > >