From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398AbdBZT4n (ORCPT ); Sun, 26 Feb 2017 14:56:43 -0500 Received: from mout.gmx.net ([212.227.15.18]:63779 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbdBZT4l (ORCPT ); Sun, 26 Feb 2017 14:56:41 -0500 Date: Sun, 26 Feb 2017 20:56:22 +0100 (CET) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Javier Martinez Canillas cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table In-Reply-To: <20170222161129.28613-1-javier@osg.samsung.com> Message-ID: References: <20170222161129.28613-1-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Provags-ID: V03:K0:sMDpjnQW4GU7TP7yCvxBnzaHevXJ9FO6xmRn4uut29Yy0n0JZ2V nkQUljTTcpwbJPZbeb0fufejwk8tfp4KMiz+WmbKE5AwfW0Ph65NMnr011FPv9YMgd6FDy4 qRmqaGwQFWpoFIHsMCb+bBMcLKetdFhvlRKe0Uf39NyX5ACBzvYNVlnLLpwi+zNEBtqueDv e1hLcJ8VAx7s3uOUZhqMg== X-UI-Out-Filterresults: notjunk:1;V01:K0:hf0Jw0F4h6Y=:1ILDb2BLt/DwphKtF1Utzq SvwFarJdaktbXN92NQyFi7LCLbdl1QMXjcKEUc9e5mWPa1vgZyWSjH537yV98ocxYoadcKF2n lVfXOqAj1kah5stc5EILApZE8JJ31FtgHyZn3Nc4U7aoJG7VKhGPZNKJL+9waP88e9lWkCknJ j5Sb9QbCgv8Q/CaqsS2c9n8JdV/g7vMqPr5aj4LZC2NOHBxIq+ROBZpqMlyI2ZhZEJB2vfmod lAtGhhmvRcG2AL6J8OfTM4+sTZfqrxbJzy/TGTW/pjqGr0Iy2Nc/wpPvvE3Btxt/IvFefkIem DJe5TOjlh44twNtVN3QapvjKSx/NjCXBhuDgwPWOqCBORF+wFMRQ7ZKHa7m67sdDe33vaMJMY 4ZJ7Y67cvRGzk9uwOjRAN0VaTDr0reogX5wKT2lLWQOE7YjZmHs7Il7yd2QOD0XayRVvSXqY+ 21JL982LAOKOOeN4hsceS0g2KKL6pMdnAgUNdoUaFesfTRdE9J5H3gYmlaYYwbv3IFmSU5w+X bDhTGbgSy4GEyKBvqJaqjvMtd9PU614bn/VZQYltM6fPLLuEMTfagivIsBn60PGdHu9e1bhIz +agyIR7rHPcwiZseA95GWL8n9xYoatUEvsPiKEV8x0YyQpd4MVlDwo6wi3D1APv+XjnfOjU0f BjyQ+2EZT8y3zNZDN3jSerUMTaDYRzO8DYF6ByE7xNcIXHKnLuaQcBNdEDvrthyhRzaF8y6Cs OYVhnI2/GDLzqGDg6IWIRsL4QWnQCZxZOyxETvdeb9qzTTOmruw/Cnlimdd187LhCopGTMPpY GDPkP47 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Feb 2017, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas Acked-by: Guennadi Liakhovetski > --- > > drivers/media/i2c/soc_camera/ov5642.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/media/i2c/soc_camera/ov5642.c b/drivers/media/i2c/soc_camera/ov5642.c > index 3d185bd622a3..1926f382dfce 100644 > --- a/drivers/media/i2c/soc_camera/ov5642.c > +++ b/drivers/media/i2c/soc_camera/ov5642.c > @@ -1063,9 +1063,18 @@ static const struct i2c_device_id ov5642_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, ov5642_id); > > +#if IS_ENABLED(CONFIG_OF) > +static const struct of_device_id ov5642_of_match[] = { > + { .compatible = "ovti,ov5642" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, ov5642_of_match); > +#endif > + > static struct i2c_driver ov5642_i2c_driver = { > .driver = { > .name = "ov5642", > + .of_match_table = of_match_ptr(ov5642_of_match), > }, > .probe = ov5642_probe, > .remove = ov5642_remove, > -- > 2.9.3 >