From: Meelis Roos <mroos@linux.ee>
To: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: integer overflow in i2o_block
Date: Thu, 26 Jul 2007 23:30:01 +0300 (EEST) [thread overview]
Message-ID: <Pine.SOC.4.64.0707262322240.7082@math.ut.ee> (raw)
Got this warning on 32-bit ppc, seems real? And it seems I2O
subsystem has no maintainer (only DPT_I2O has one)?
CC [M] drivers/message/i2o/i2o_block.o
drivers/message/i2o/i2o_block.c: In function 'i2o_block_transfer':
drivers/message/i2o/i2o_block.c:837: warning: integer overflow in expression
The line in question is
msg->u.head[1] = cpu_to_le32(I2O_CMD_PRIVATE << 24 | HOST_TID << 12 | tid);
and I2O_CMD_PRIVATE is defined as 0xFF. This gets "0xFF0100 | tid" and
fits into 32-bit unsigned but not into 32-bit signed integer properly.
Target value head[*] is defined as u32 so the claculation does not fit
during computation? Should we mark the shiftable inputas as unsigned?
--
Meelis Roos (mroos@linux.ee)
next reply other threads:[~2007-07-26 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 20:30 Meelis Roos [this message]
2007-07-26 20:48 ` Salyzyn, Mark
2007-07-27 15:45 ` [PATCH] fix integer overflow warning " Meelis Roos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SOC.4.64.0707262322240.7082@math.ut.ee \
--to=mroos@linux.ee \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®