mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Meelis Roos <mroos@linux.ee>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Jay Estabrook <jay.estabrook@hp.com>
Subject: Re: alpha compile failure (srm_printk)
Date: Sat, 28 Jul 2007 20:05:08 +0300 (EEST)	[thread overview]
Message-ID: <Pine.SOC.4.64.0707281950340.20474@math.ut.ee> (raw)
In-Reply-To: <20070605231712.ff1df46f.akpm@linux-foundation.org>

Retested this compile error with todays 2.6.23-rc1+git, still the same.

> >   LD      arch/alpha/boot/bootloader
> > arch/alpha/boot/bootloader.lds:25: undefined symbol `srm_printk' referenced in expression
> 
> I was unable to repeoduce these errors on 2.6.22-rc4 with your config.

Hmm. Just make works, make bootimage does not. I debugged this further 
today and I can not see how it can work.

The link command in question is
ld   -static -uvsprintf -T   arch/alpha/boot/bootloader.lds arch/alpha/boot/head.o arch/alpha/boot/main.o -o arch/alpha/boot/bootloader
and it still tells
arch/alpha/boot/bootloader.lds:25: undefined symbol `srm_printk' referenced in expression

arch/alpha/boot/bootloader.lds contains a single related line referring 
to srm_printk:
printk = srm_printk;
This only seems to define an alias to srm_printk so not important (and 
unused)?

nm arch/alpha/boot/head.o outputs
0000000000000000 T __start
0000000000000108 T halt
0000000000000110 T move_stack
                 U start_kernel
0000000000000060 T switch_to_osf_pal
0000000000000100 T tbi
0000000000000020 T wrent
0000000000000040 T wrkg

so no mention of srm_printk.

nm arch/alpha/boot/main.o outputs
                 U _end
                 U callback_close
                 U callback_getenv
                 U callback_open
                 U callback_read
0000000000000000 G hwrpb
0000000000000000 T pal_init
0000000000000000 b pcb_va
                 U srm_printk
0000000000000130 T start_kernel
                 U strcpy
                 U switch_to_osf_pal

and the U srm_printk is breaking things. main.c actually uses srm_printk 
inside so it really needs to link one in. I do not see where that 
srm_printk could come from? The only implementation seems to be in 
arch/alpha/lib/srm_printk.c that goes into arch/alpha/lib/lib.a.. maybe 
this is forgotten?

arch/alpha/boot/Makefile contains different link rules for bootloader vs 
bootpheader and bootpzheader - the others also have $(LIBS_Y). However, 
as trial and error showed, adding $(LIBS_Y) to get lib/lib.a does not 
work - I got new unresolved symbols (__kmalloc or some other malloc 
variant).

So, can anyone guide me further - where should srm_printk come from in 
bootloader image?

-- 
Meelis Roos (mroos@linux.ee)

  parent reply	other threads:[~2007-07-28 17:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-04 11:21 Meelis Roos
2007-06-06  6:17 ` Andrew Morton
2007-06-06  7:48   ` Meelis Roos
2007-07-28 17:05   ` Meelis Roos [this message]
2007-07-28 20:04     ` Sam Ravnborg
2007-07-28 20:20       ` [PATCH] lib: move kasprintf to a separate file Sam Ravnborg
2007-07-28 20:52         ` [PATCH] add a missing LIB_Y to arch/alpha/boot Makefile Meelis Roos
2007-07-28 22:48         ` [PATCH] lib: move kasprintf to a separate file Jeremy Fitzhardinge
2007-07-29 20:08           ` Sam Ravnborg
2007-07-28 20:21       ` alpha compile failure (srm_printk) Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SOC.4.64.0707281950340.20474@math.ut.ee \
    --to=mroos@linux.ee \
    --cc=akpm@linux-foundation.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jay.estabrook@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®