From: Finn Thain <fthain@telegraphics.com.au>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-m68k@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net] macmace: Set platform device coherent_dma_mask
Date: Thu, 03 May 2018 14:23:55 +1000 [thread overview]
Message-ID: <S1751901AbeECEYC/20180503042404Z+257@vger.kernel.org> (raw)
Set the device's coherent_dma_mask to avoid a WARNING splat.
Please see commit 205e1b7f51e4 ("dma-mapping: warn when there is
no coherent_dma_mask").
Cc: linux-m68k@lists.linux-m68k.org
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/net/ethernet/apple/macmace.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/apple/macmace.c b/drivers/net/ethernet/apple/macmace.c
index 137cbb470af2..98292c49ecf0 100644
--- a/drivers/net/ethernet/apple/macmace.c
+++ b/drivers/net/ethernet/apple/macmace.c
@@ -203,6 +203,10 @@ static int mace_probe(struct platform_device *pdev)
unsigned char checksum = 0;
int err;
+ err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
+ if (err)
+ return err;
+
dev = alloc_etherdev(PRIV_BYTES);
if (!dev)
return -ENOMEM;
--
2.16.1
next reply other threads:[~2018-05-03 4:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 4:23 Finn Thain [this message]
[not found] <S1751632AbeECEYA/20180503042400Z+254@vger.kernel.org>
2018-05-03 7:25 ` Geert Uytterhoeven
2018-05-03 8:38 ` Finn Thain
2018-05-03 8:46 ` Geert Uytterhoeven
2018-05-03 8:51 ` Christoph Hellwig
2018-05-03 20:24 ` Michael Schmitz
2018-05-04 7:24 ` Geert Uytterhoeven
2018-05-04 8:16 ` Michael Schmitz
2018-05-10 1:25 ` Finn Thain
2018-05-10 1:25 ` Finn Thain
2018-05-10 20:27 ` Michael Schmitz
2018-05-10 23:55 ` Finn Thain
2018-05-11 2:11 ` Michael Schmitz
2018-05-11 3:28 ` Finn Thain
2018-05-11 4:18 ` Michael Schmitz
2018-05-11 5:28 ` Finn Thain
2018-05-11 9:30 ` Michael Schmitz
2018-05-11 10:06 ` Finn Thain
2018-05-11 22:02 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=S1751901AbeECEYC/20180503042404Z+257@vger.kernel.org \
--to=fthain@telegraphics.com.au \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®