From: Ankit Agrawal <ankita@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
Yishai Hadas <yishaih@nvidia.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"kevin.tian@intel.com" <kevin.tian@intel.com>,
Zhi Wang <zhiw@nvidia.com>, Aniket Agashe <aniketa@nvidia.com>,
Neo Jia <cjia@nvidia.com>, Kirti Wankhede <kwankhede@nvidia.com>,
"Tarun Gupta (SW-GPU)" <targupta@nvidia.com>,
Vikram Sethi <vsethi@nvidia.com>,
Andy Currid <acurrid@nvidia.com>,
Alistair Popple <apopple@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
Dan Williams <danw@nvidia.com>,
"Anuj Aggarwal (SW-GPU)" <anuaggarwal@nvidia.com>,
Matt Ochs <mochs@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] vfio/nvgrace-gpu: Check the HBM training and C2C link status
Date: Fri, 17 Jan 2025 19:19:42 +0000 [thread overview]
Message-ID: <SA1PR12MB7199C77BE13F375ACFE4377EB01B2@SA1PR12MB7199.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20250117132736.408954ac.alex.williamson@redhat.com>
>> +/*
>> + * To reduce the system bootup time, the HBM training has
>> + * been moved out of the UEFI on the Grace-Blackwell systems.
>> + *
>> + * The onus of checking whether the HBM training has completed
>> + * thus falls on the module. The HBM training status can be
>> + * determined from a BAR0 register.
>> + *
>> + * Similarly, another BAR0 register exposes the status of the
>> + * CPU-GPU chip-to-chip (C2C) cache coherent interconnect.
>> + *
>> + * Poll these register and check for 30s. If the HBM training is
>> + * not complete or if the C2C link is not ready, fail the probe.
>> + *
>> + * While the wait is not required on Grace Hopper systems, it
>> + * is beneficial to make the check to ensure the device is in an
>> + * expected state.
>> + */
>> +static int nvgrace_gpu_wait_device_ready(struct pci_dev *pdev)
>> +{
>> + unsigned long timeout = jiffies + msecs_to_jiffies(POLL_TIMEOUT_MS);
>> + void __iomem *io;
>> + int ret = -ETIME;
>> +
>> + io = pci_iomap(pdev, 0, 0);
>> + if (!io)
>> + return -ENOMEM;
>> +
>> + do {
>> + if ((ioread32(io + C2C_LINK_BAR0_OFFSET) == STATUS_READY) &&
>> + (ioread32(io + HBM_TRAINING_BAR0_OFFSET) == STATUS_READY)) {
>> + ret = 0;
>> + goto reg_check_exit;
>> + }
>> + msleep(POLL_QUANTUM_MS);
>> + } while (!time_after(jiffies, timeout));
>> +
>> +reg_check_exit:
>> + pci_iounmap(pdev, io);
>> + return ret;
>
> We're accessing device memory here but afaict the memory enable bit of
> the command register is in an indeterminate state. What happens if you
> use setpci to clear the memory enable bit or 'echo 0 > enable' before
> binding the driver? Thanks,
>
> Alex
Hi Alex, sorry I didn't understand how we are accessing device memory here if
the C2C_LINK_BAR0_OFFSET and HBM_TRAINING_BAR0_OFFSET are BAR0 regs.
But anyways, I tried 'echo 0 > <sysfs_path>/enable' before device bind. I am not
observing any issue and the bind goes through.
Or am I missing something?
next prev parent reply other threads:[~2025-01-17 19:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 15:23 [PATCH v3 0/3] vfio/nvgrace-gpu: Enable grace blackwell boards ankita
2025-01-17 15:23 ` [PATCH v3 1/3] vfio/nvgrace-gpu: Read dvsec register to determine need for uncached resmem ankita
2025-01-17 15:23 ` [PATCH v3 2/3] vfio/nvgrace-gpu: Expose the blackwell device PF BAR1 to the VM ankita
2025-01-17 18:06 ` Alex Williamson
2025-01-17 18:48 ` Ankit Agrawal
2025-01-17 15:23 ` [PATCH v3 3/3] vfio/nvgrace-gpu: Check the HBM training and C2C link status ankita
2025-01-17 18:27 ` Alex Williamson
2025-01-17 19:19 ` Ankit Agrawal [this message]
2025-01-17 19:39 ` Alex Williamson
2025-01-17 21:13 ` Ankit Agrawal
2025-01-17 21:31 ` Alex Williamson
2025-01-17 21:45 ` Ankit Agrawal
2025-01-17 21:56 ` Ankit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR12MB7199C77BE13F375ACFE4377EB01B2@SA1PR12MB7199.namprd12.prod.outlook.com \
--to=ankita@nvidia.com \
--cc=acurrid@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=aniketa@nvidia.com \
--cc=anuaggarwal@nvidia.com \
--cc=apopple@nvidia.com \
--cc=cjia@nvidia.com \
--cc=danw@nvidia.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochs@nvidia.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=targupta@nvidia.com \
--cc=vsethi@nvidia.com \
--cc=yishaih@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®