mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jones Syue 薛懷宗" <jonessyue@qnap.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"j.vosburgh@gmail.com" <j.vosburgh@gmail.com>,
	"andy@greyhouse.net" <andy@greyhouse.net>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] bonding: 802.3ad replace MAC_ADDRESS_EQUAL with __agg_has_partner
Date: Fri, 23 Feb 2024 10:03:38 +0000	[thread overview]
Message-ID: <SI2PR04MB50979AE205E6027BA35B8599DC552@SI2PR04MB5097.apcprd04.prod.outlook.com> (raw)
In-Reply-To: <ZdhNxWivTVixYRFK@Laptop-X1>

Hello Hangbin,

> MAC_ADDRESS_EQUAL and __agg_has_partner are not the same thing.
> 
> MAC_ADDRESS_EQUAL() is only same with __agg_has_partner() when verifying
> agg partner mac addr with null_mac_addr. The description could be more
> accurate.

Thank you for kindly reply! Yes you are right my description is not clear.

> Since you want to replace the null_mac_addr checking for MAC_ADDRESS_EQUAL().
> Maybe we can also replace the null_mac_addr checking in
> ad_port_selection_logic(). This should be safe as the
> aggregator->partner_system and port->partner_oper.system has been compared.
> e.g.
> ...
> With this the null_mac_addr definition could be removed.

This new one looks better! Will come out a v3 and test it :)

--

Regards,
Jones Syue | 薛懷宗
QNAP Systems, Inc.

      reply	other threads:[~2024-02-23 10:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23  4:12 Jones Syue 薛懷宗
2024-02-23  7:48 ` Hangbin Liu
2024-02-23 10:03   ` Jones Syue 薛懷宗 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SI2PR04MB50979AE205E6027BA35B8599DC552@SI2PR04MB5097.apcprd04.prod.outlook.com \
    --to=jonessyue@qnap.com \
    --cc=andy@greyhouse.net \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=j.vosburgh@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®