From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 374F1C43381 for ; Fri, 22 Jan 2021 14:43:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0972E239D1 for ; Fri, 22 Jan 2021 14:43:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728847AbhAVOno convert rfc822-to-8bit (ORCPT ); Fri, 22 Jan 2021 09:43:44 -0500 Received: from aposti.net ([89.234.176.197]:55628 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728886AbhAVOnW (ORCPT ); Fri, 22 Jan 2021 09:43:22 -0500 Date: Fri, 22 Jan 2021 14:42:28 +0000 From: Paul Cercueil Subject: Re: [PATCH 1/2] dt-bindings/phy: ingenic: Add compatibles =?UTF-8?Q?for=0D=0A?= JZ4760(B) SoCs To: Rob Herring Cc: Kishon Vijay Abraham I , Vinod Koul , od@zcrc.me, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: References: <20210120115945.29046-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Le ven. 22 janv. 2021 à 8:35, Rob Herring a écrit : > On Wed, Jan 20, 2021 at 5:59 AM Paul Cercueil > wrote: >> >> Add the ingenic,jz4760-phy and ingenic,jz4760b-phy compatible >> strings, >> and make the ingenic,jz4770-phy compatible string require >> ingenic,jz4760-phy as a fallback, since both work the same, and the >> JZ4760 SoC is older. >> >> Signed-off-by: Paul Cercueil >> --- >> .../bindings/phy/ingenic,phy-usb.yaml | 22 >> ++++++++++++------- >> 1 file changed, 14 insertions(+), 8 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml >> b/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml >> index 0fd93d71fe5a..3c65dfcf352b 100644 >> --- a/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml >> +++ b/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml >> @@ -15,13 +15,19 @@ properties: >> pattern: '^usb-phy@.*' >> >> compatible: >> - enum: >> - - ingenic,jz4770-phy >> - - ingenic,jz4775-phy >> - - ingenic,jz4780-phy >> - - ingenic,x1000-phy >> - - ingenic,x1830-phy >> - - ingenic,x2000-phy >> + oneOf: >> + - enum: >> + - ingenic,jz4760-phy > > This should be 2 more spaces indentation. Indent is always 2 more than > the above keyword and ignores '-'. Pretty confusing. But alright. Cheers, -Paul >> + - ingenic,jz4775-phy >> + - ingenic,jz4780-phy >> + - ingenic,x1000-phy >> + - ingenic,x1830-phy >> + - ingenic,x2000-phy >> + - items: >> + - enum: >> + - ingenic,jz4760b-phy >> + - ingenic,jz4770-phy >> + - const: ingenic,jz4760-phy >> >> reg: >> maxItems: 1 >> @@ -48,7 +54,7 @@ examples: >> - | >> #include >> otg_phy: usb-phy@3c { >> - compatible = "ingenic,jz4770-phy"; >> + compatible = "ingenic,jz4770-phy", "ingenic,jz4760-phy"; >> reg = <0x3c 0x10>; >> >> vcc-supply = <&vcc>; >> -- >> 2.29.2 >>