From: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
To: "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"logang@deltatee.com" <logang@deltatee.com>
Subject: Re: [PATCH 0/1] Add support for setting MMIO PREF hotplug bridge size
Date: Wed, 23 Oct 2019 10:43:53 +0000 [thread overview]
Message-ID: <SL2P216MB0187DC3EEA0B3FD8D4F81B45806B0@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20191023094522.GT2819@lahna.fi.intel.com>
On Wed, Oct 23, 2019 at 12:45:22PM +0300, mika.westerberg@linux.intel.com wrote:
> On Wed, Oct 23, 2019 at 08:36:59AM +0000, Nicholas Johnson wrote:
> > This patch adds support for two new kernel parameters. This patch has
> > been in the making for quite some time, and has changed several times
> > based on feedback.
> >
> > I realised I was making the mistake of putting it as part of my
> > Thunderbolt patch series. Although the other patches in the series are
> > very important for my goal, I realised that they are just a heap of
> > patches that are not Thunderbolt-specific. The only thing that is
> > Thunderbolt-related is the intended use case.
> >
> > I hope that posting this alone can ease the difficulty of reviewing it.
> >
> > Nicholas Johnson (1):
> > PCI: Add hp_mmio_size and hp_mmio_pref_size parameters
> >
> > .../admin-guide/kernel-parameters.txt | 9 ++++++-
> > drivers/pci/pci.c | 17 ++++++++++---
> > drivers/pci/pci.h | 3 ++-
> > drivers/pci/setup-bus.c | 25 +++++++++++--------
> > 4 files changed, 38 insertions(+), 16 deletions(-)
>
> If you want to add cover letter in the "normal way" so that threading is
> preserved you can do something like 'git format-patch --cover-letter ...',
> then edit the 0000-...patch and send it along with the other patches
I do everything above.
> using git send-email.
But I was told by Bjorn that I was sending emails with funny encoding
which meant he had to manually apply the patches, which meant more work
for him. I could not figure out how to make git send-email work with the
correct encoding. I had to use mutt -H to fix the encoding, doing each
email separately.
I have no idea why my git send-email is strange.
prev parent reply other threads:[~2019-10-23 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 8:36 Nicholas Johnson
2019-10-23 9:45 ` mika.westerberg
2019-10-23 10:43 ` Nicholas Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SL2P216MB0187DC3EEA0B3FD8D4F81B45806B0@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM \
--to=nicholas.johnson-opensource@outlook.com.au \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®