RE: [PATCH v7 6/9] media: chips-media: wave6: Improve debugging capabilities

[Nas Chung <nas.chung@chipsnmedia.com>]

Hi, Frank.

>-----Original Message-----
>From: Frank Li <Frank.li@oss.nxp.com>
>Sent: Thursday, September 10, 2026 5:41 AM
>To: Nas Chung <nas.chung@chipsnmedia.com>
>Cc: mchehab@kernel.org; hverkuil@xs4all.nl; robh@kernel.org;
>krzk+dt@kernel.org; conor+dt@kernel.org; shawnguo@kernel.org;
>s.hauer@pengutronix.de; linux-media@vger.kernel.org;
>devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-imx@nxp.com;
>linux-arm-kernel@lists.infradead.org; jackson.lee
><jackson.lee@chipsnmedia.com>; lafley.kim <lafley.kim@chipsnmedia.com>;
>marek.vasut@mailbox.org; Ming Qian <ming.qian@oss.nxp.com>
>Subject: Re: [PATCH v7 6/9] media: chips-media: wave6: Improve debugging
>capabilities
>
>On Fri, Sep 04, 2026 at 03:46:32PM +0900, Nas Chung wrote:
>
>media: chips-media: wave6: Add trace and debugfs

I'll address this in v8.

>
>> Add debugfs entries and trace events to provide detailed
>> debugging information.
>
>Nit: need extra space line here.

OK.

>
>> These enhancements help diagnose issues and improve debugging
>
>Remove "These enhancements".

I'll remove it.

...

>
>> +
>> +#ifndef __WAVE6_VPU_DBG_H__
>> +#define __WAVE6_VPU_DBG_H__
>> +
>> +int wave6_vpu_create_dbgfs_file(struct vpu_instance *inst);
>> +void wave6_vpu_remove_dbgfs_file(struct vpu_instance *inst);
>
>You add this patch 6. but call this funcation at patch 4.
>
>You need make sure each patch can build without break bisect.

You are right that patch 4 calls what patch 6 declares.

But the build does not break: wave6/Kconfig and wave6/Makefile are added in
patch 8, so nothing under wave6/ is compiled in patches 3-7. I built every
commit individually.

Thanks.
Nas.

>
>Frank
>
>> +
>> +#endif /* __WAVE6_VPU_DBG_H__ */
>> --
>> 2.31.1
>>