From: 王擎 <wangqing@vivo.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 回复: [PATCH] tty: 8250: replace snprintf in show functions with sysfs_emit
Date: Fri, 15 Oct 2021 07:13:58 +0000 [thread overview]
Message-ID: <SL2PR06MB30828C16C885776950205E5DBDB99@SL2PR06MB3082.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <AOQACwDzEi5UM3m3ezm-D4o5.9.1634281082401.Hmail.wangqing@vivo.com>
>> show() must not use snprintf() when formatting the value to be
>> returned to user space.
>
>Why must it not? What is broken in the existing code?
Replyed in another email.
>
>>
>> Fix the coccicheck warnings:
>> WARNING: use scnprintf or sprintf.
>>
>> Signed-off-by: Qing Wang <wangqing@vivo.com>
>> ---
>> drivers/tty/serial/8250/8250_aspeed_vuart.c | 6 +++---
>> drivers/tty/serial/8250/8250_port.c | 2 +-
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c
>> index 2350fb3..082b9bd 100644
>> --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c
>> +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c
>> @@ -82,7 +82,7 @@ static ssize_t lpc_address_show(struct device *dev,
>> addr = (aspeed_vuart_readb(vuart, ASPEED_VUART_ADDRH) << 8) |
>> (aspeed_vuart_readb(vuart, ASPEED_VUART_ADDRL));
>>
>> - return snprintf(buf, PAGE_SIZE - 1, "0x%x\n", addr);
>> + return sysfs_emit(buf - 1, "0x%x\n", addr);
>
>what is the buf-1 thing here for?
>
>Doing a tree-wide change for this type of thing might not be wanted by
>many maintainers, especially if you introduce bugs like this :(
Sorry for this, my tool needs to be optimized.
Please ignore this patch.
Thanks,
Qing
>
>greg k-h
>
prev parent reply other threads:[~2021-10-15 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 6:51 Qing Wang
2021-10-15 6:57 ` Greg Kroah-Hartman
[not found] ` <AOQACwDzEi5UM3m3ezm-D4o5.9.1634281082401.Hmail.wangqing@vivo.com>
2021-10-15 7:13 ` 王擎 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SL2PR06MB30828C16C885776950205E5DBDB99@SL2PR06MB3082.apcprd06.prod.outlook.com \
--to=wangqing@vivo.com \
--cc=andrew@aj.id.au \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®