mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ki-Seok Jo <kiseok.jo@irondevice.com>
To: Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: dt-bindings: Drop broken irondevice,sma1303 binding
Date: Thu, 2 Feb 2023 01:54:40 +0000	[thread overview]
Message-ID: <SLXP216MB00776F066D70DB2F3F77B09E8CD69@SLXP216MB0077.KORP216.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <Y9p+p6wt8WugDBuH@sirena.org.uk>

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

> On Wed, Feb 01, 2023 at 03:43:12PM +0100, Krzysztof Kozlowski wrote:
> 
> > I tried. I started writing patch to fix few things in this binding and
> > then noticed that it is entirely empty and documents nothing.
> 
> I really don't see an empty binding as a major problem in and of itself,
> we can always add properties later.  Again, I can't tell what the problems
> you're seeing are.
> 
> > The trouble is that soon you will send it to Linus and then it becomes
> > the ABI even though no one ever approved or reviewed the actual ABI.
> 
> So send a patch to delete the property parsing code then, like I say
> removing the entire driver is very much an overraction.  The properties are
> all optional in the code.

Ok. I'm sorry for not checking correctly.
I only reviewed using the full source build and checkpatch.pl.
But I missed the config setting...

So, could I get the information how to test the binding files?
From what I've checked now, using make dt_binding_check, right?

I'll try to read again like submitting-patches.rst and writing-bindings.rst.
And then re-write the patch. I'm sorry again for not checking properly.


Thanks Mark and Krzysztof to feedback.

Best Regards,
Kiseok Jo

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]

  reply	other threads:[~2023-02-02  1:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01 13:10 Krzysztof Kozlowski
2023-02-01 13:13 ` Krzysztof Kozlowski
2023-02-01 14:03   ` Mark Brown
2023-02-01 14:43     ` Krzysztof Kozlowski
2023-02-01 15:00       ` Mark Brown
2023-02-02  1:54         ` Ki-Seok Jo [this message]
2023-02-02  5:28           ` Ki-Seok Jo
2023-02-02  8:44             ` Krzysztof Kozlowski
2023-02-02  8:58               ` Ki-Seok Jo
2023-02-02  9:03                 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SLXP216MB00776F066D70DB2F3F77B09E8CD69@SLXP216MB0077.KORP216.PROD.OUTLOOK.COM \
    --to=kiseok.jo@irondevice.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®