From: Victor Chernyakin <chernyakin.victor.j@outlook.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Victor Chernyakin <chernyakin.victor.j@outlook.com>
Subject: [RFC PATCH 0/2] regmap: add APIs to bypass regmap_field and work with reg_field directly
Date: Wed, 4 Nov 2026 18:09:48 -0600 [thread overview]
Message-ID: <SN1PR12MB2528754CEF9D8E5103ECAE28A5772@SN1PR12MB2528.namprd12.prod.outlook.com> (raw)
Working with the existing regmap_field_* APIs requires you to define
a reg_field, then use one of the regmap_field_*_alloc functions to turn
it into a dynamically allocated regmap_field. But reg_field and
regmap_field are practically the same struct; all the *_alloc functions do
is shuffle fields around. So this RFC proposes adding functions that
cut out the middleman and take reg_field directly. Patch 1 adds two
of them: regmap_reg_field_read and regmap_reg_field_write.
Patch 2 ports a driver to use these new functions. The result is
shorter and simpler, since all the code to perform the allocations
and manage the resulting regmap_fields goes away. In theory,
there should also be a performance benefit (we're doing fewer allocations
and have less duplicated state), but I haven't benchmarked it, so take that
with a grain of salt.
If we like this approach, I can post a v2 that adds regmap_reg_field_*
analogs for all the regmap_field_* functions, not just the two you see here.
This is not actually a new idea! Both it and the current *_alloc approach
were suggested as alternatives right when the regmap_field_* APIs were
being added [1]. The *_alloc approach was chosen without much
discussion, but I think (and Patch 2 demonstrates, I hope) that
this approach is the cleaner one.
[1] https://lore.kernel.org/20130604210137.GV31367@sirena.org.uk
Victor Chernyakin (2):
regmap: add regmap_reg_field_* APIs
iio: accel: msa311: use regmap_reg_field_* functions
drivers/iio/accel/msa311.c | 297 +++++++++++++------------------------
include/linux/regmap.h | 61 ++++++--
2 files changed, 158 insertions(+), 200 deletions(-)
--
2.53.0
next reply other threads:[~2026-11-05 0:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 0:09 Victor Chernyakin [this message]
2026-11-05 0:09 ` [RFC PATCH 1/2] regmap: add regmap_reg_field_* APIs Victor Chernyakin
2026-11-05 0:09 ` [RFC PATCH 2/2] iio: accel: msa311: use regmap_reg_field_* functions Victor Chernyakin
2026-11-05 10:36 ` Andy Shevchenko
2026-11-05 0:19 ` [RFC PATCH 0/2] regmap: add APIs to bypass regmap_field and work with reg_field directly Mark Brown
2026-11-05 0:23 ` Victor Chernyakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN1PR12MB2528754CEF9D8E5103ECAE28A5772@SN1PR12MB2528.namprd12.prod.outlook.com \
--to=chernyakin.victor.j@outlook.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®