From: Parshuram Raju Thombare <pthombar@cadence.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rafal Ciepiela <rafalc@cadence.com>,
Anil Joy Varughese <aniljoy@cadence.com>,
Piotr Sroka <piotrs@cadence.com>
Subject: RE: [PATCH v5 4/5] net: macb: add support for high speed interface
Date: Tue, 25 Jun 2019 08:55:14 +0000 [thread overview]
Message-ID: <SN2PR07MB248006F5B8955EB7311B7DCEC1E30@SN2PR07MB2480.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20190624134755.u3oq3xr6uergnfs5@shell.armlinux.org.uk>
>> +static inline void gem_mac_configure(struct macb *bp, int speed)
>> + switch (speed) {
>> + case SPEED_1000:
>> + gem_writel(bp, NCFGR, GEM_BIT(GBE) |
>> + gem_readl(bp, NCFGR));
>> + break;
>> + case SPEED_100:
>> + macb_writel(bp, NCFGR, MACB_BIT(SPD) |
>> + macb_readl(bp, NCFGR));
>What happens to the NCFGR register if we call mac_config() first for
>a 1G speed, then 100M and finally 10M - what value does the NCFGR
>register end up with?
>
>I suspect it ends up with both the GBE and SPD bits set, and that is
>probably not what you want.
No, In gem_mac_config GBE and SPD bits are always cleared
before setting appropriate bits as per requested speed, duplex mode.
Regards,
Parshuram Thombare
next prev parent reply other threads:[~2019-06-25 8:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 12:10 [PATCH v5 0/5] net: macb: cover letter Parshuram Thombare
2019-06-24 12:10 ` [PATCH v5 1/5] net: macb: add phylink support Parshuram Thombare
2019-06-24 12:11 ` [PATCH v5 2/5] net: macb: add support for sgmii MAC-PHY interface Parshuram Thombare
2019-06-24 13:42 ` Russell King - ARM Linux admin
2019-06-25 9:26 ` Parshuram Raju Thombare
2019-06-25 9:29 ` Russell King - ARM Linux admin
2019-06-25 9:38 ` Parshuram Raju Thombare
2019-06-25 10:34 ` Russell King - ARM Linux admin
2019-06-25 11:22 ` Parshuram Raju Thombare
2019-06-24 12:11 ` [PATCH v5 3/5] net: macb: add support for c45 PHY Parshuram Thombare
2019-06-24 12:12 ` [PATCH v5 4/5] net: macb: add support for high speed interface Parshuram Thombare
2019-06-24 13:47 ` Russell King - ARM Linux admin
2019-06-25 8:49 ` Parshuram Raju Thombare
2019-06-25 9:03 ` Russell King - ARM Linux admin
2019-06-25 9:29 ` Parshuram Raju Thombare
2019-06-25 8:55 ` Parshuram Raju Thombare [this message]
2019-06-24 12:12 ` [PATCH v5 5/5] net: macb: parameter added to cadence ethernet controller DT binding Parshuram Thombare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN2PR07MB248006F5B8955EB7311B7DCEC1E30@SN2PR07MB2480.namprd07.prod.outlook.com \
--to=pthombar@cadence.com \
--cc=andrew@lunn.ch \
--cc=aniljoy@cadence.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=piotrs@cadence.com \
--cc=rafalc@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®