mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nava kishore Manne <navam@xilinx.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	"mdf@kernel.org" <mdf@kernel.org>,
	"hao.wu@intel.com" <hao.wu@intel.com>,
	"yilun.xu@intel.com" <yilun.xu@intel.com>,
	"trix@redhat.com" <trix@redhat.com>,
	Michal Simek <michals@xilinx.com>,
	"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 4/6] fpga: fpga-mgr: Add missing kernel-doc description
Date: Tue, 15 Mar 2022 11:51:57 +0000	[thread overview]
Message-ID: <SN6PR02MB4576356531DD49BAF45FE28AC2109@SN6PR02MB4576.namprd02.prod.outlook.com> (raw)
In-Reply-To: <f28c49a8-4e5a-5601-4d0b-05d34024779f@infradead.org>

Hi Randy,

	Thanks for providing the review comments.
Please find response inline.

> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Wednesday, March 9, 2022 3:09 AM
> To: Nava kishore Manne <navam@xilinx.com>; mdf@kernel.org;
> hao.wu@intel.com; yilun.xu@intel.com; trix@redhat.com; Michal Simek
> <michals@xilinx.com>; linux-fpga@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 4/6] fpga: fpga-mgr: Add missing kernel-doc description
> 
> Hi--
> 
> On 3/8/22 01:45, Nava kishore Manne wrote:
> > Fixed the warnings: Function parameter or member 'xxx' not described.
> >
> > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > ---
> >  drivers/fpga/fpga-mgr.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index
> > a699cc8e2fa6..354789740529 100644
> > --- a/drivers/fpga/fpga-mgr.c
> > +++ b/drivers/fpga/fpga-mgr.c
> > @@ -730,6 +730,8 @@ static void devm_fpga_mgr_unregister(struct
> device *dev, void *res)
> >   * @parent:	fpga manager device from pdev
> >   * @info:	parameters for fpga manager
> >   *
> > + * @return:  fpga manager pointer on success, negative error code
> otherwise.
> 
> Not quite. Should be:
> 
>  * Return: foo bar blah
> 

Will fix in v2

> > + *
> >   * This is the devres variant of fpga_mgr_register_full() for which the
> unregister
> >   * function will be called automatically when the managing device is
> detached.
> >   */
> > @@ -763,6 +765,8 @@
> EXPORT_SYMBOL_GPL(devm_fpga_mgr_register_full);
> >   * @mops:	pointer to structure of fpga manager ops
> >   * @priv:	fpga manager private data
> >   *
> > + * @return:  fpga manager pointer on success, negative error code
> otherwise.
> 
> ditto.
> 

Will fix in v2.

Regards,
Navakishore.

  reply	other threads:[~2022-03-15 11:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08  9:45 [PATCH 0/6]fpga: fix for coding style and kernel-doc issues Nava kishore Manne
2022-03-08  9:45 ` [PATCH 1/6] fpga: zynq: Fix incorrect variable type Nava kishore Manne
2022-03-08  9:45 ` [PATCH 2/6] fpga: zynqmp: Initialized variables before using it Nava kishore Manne
2022-03-11 14:28   ` Xu Yilun
2022-03-15 11:48     ` Nava kishore Manne
2022-03-15 16:08       ` Xu Yilun
2022-03-22  6:55         ` Nava kishore Manne
2022-03-08  9:45 ` [PATCH 3/6] fpga: fpga-mgr: fix for coding style issues Nava kishore Manne
2022-03-08  9:45 ` [PATCH 4/6] fpga: fpga-mgr: Add missing kernel-doc description Nava kishore Manne
2022-03-08 21:38   ` Randy Dunlap
2022-03-15 11:51     ` Nava kishore Manne [this message]
2022-03-08  9:45 ` [PATCH 5/6] fpga: Use tab instead of spaces for indentation Nava kishore Manne
2022-03-08  9:45 ` [PATCH 6/6] fpga: fpga-region: Add missing kernel-doc description Nava kishore Manne
2022-03-08 21:40   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR02MB4576356531DD49BAF45FE28AC2109@SN6PR02MB4576.namprd02.prod.outlook.com \
    --to=navam@xilinx.com \
    --cc=hao.wu@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=michals@xilinx.com \
    --cc=rdunlap@infradead.org \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®