mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nava kishore Manne <navam@xilinx.com>
To: Joe Perches <joe@perches.com>, "mdf@kernel.org" <mdf@kernel.org>,
	"hao.wu@intel.com" <hao.wu@intel.com>,
	"yilun.xu@intel.com" <yilun.xu@intel.com>,
	"trix@redhat.com" <trix@redhat.com>,
	Michal Simek <michals@xilinx.com>,
	"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>, git <git@xilinx.com>
Subject: RE: [PATCH v4 2/5] fpga: fix for coding style issues
Date: Mon, 18 Apr 2022 09:54:35 +0000	[thread overview]
Message-ID: <SN6PR02MB45763D1B949353F99AAFE7D8C2F39@SN6PR02MB4576.namprd02.prod.outlook.com> (raw)
In-Reply-To: <ac22068dad06fd61f2e82c0bf7c0f58a4e5df050.camel@perches.com>

Hi Joe,

	Please find my response inline.

> -----Original Message-----
> From: Joe Perches <joe@perches.com>
> Sent: Saturday, April 16, 2022 10:29 PM
> To: Nava kishore Manne <navam@xilinx.com>; mdf@kernel.org;
> hao.wu@intel.com; yilun.xu@intel.com; trix@redhat.com; Michal Simek
> <michals@xilinx.com>; linux-fpga@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; git
> <git@xilinx.com>
> Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues
> 
> On Sat, 2022-04-16 at 19:07 +0530, Nava kishore Manne wrote:
> > fixes the below checks reported by checkpatch.pl Lines should not end
> > with a '('
> > Alignment should match open parenthesis
> 
> in fpga-mgr:
> 	Another possibillty would be to change the function arguments
> 
> and
> 
> in fpga-region:
> 	Ideally keep the include declaration and definition styles synced
> 

These changes are targeted to fix the checks reported by checkpatch.pl without touching the actual functionality.

Regards,
Navakishore.

  reply	other threads:[~2022-04-18  9:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-16 13:37 [PATCH v4 0/5]fpga: fix for coding style and kernel-doc issues Nava kishore Manne
2022-04-16 13:37 ` [PATCH v4 1/5] fpga: zynq: Fix incorrect variable type Nava kishore Manne
2022-04-16 16:23   ` Xu Yilun
2022-04-16 13:37 ` [PATCH v4 2/5] fpga: fix for coding style issues Nava kishore Manne
2022-04-16 16:58   ` Joe Perches
2022-04-18  9:54     ` Nava kishore Manne [this message]
2022-04-18 12:34       ` Joe Perches
2022-04-19  8:15         ` Nava kishore Manne
2022-04-19  9:45           ` Xu Yilun
2022-04-16 17:02   ` Xu Yilun
2022-04-16 17:15     ` Xu Yilun
2022-04-16 13:37 ` [PATCH v4 3/5] fpga: fpga-mgr: fix kernel-doc warnings Nava kishore Manne
2022-04-16 16:53   ` Xu Yilun
2022-04-16 13:37 ` [PATCH v4 4/5] fpga: Use tab instead of space indentation Nava kishore Manne
2022-04-16 16:47   ` Xu Yilun
2022-04-16 13:37 ` [PATCH v4 5/5] fpga: fpga-region: fix kernel-doc formatting issues Nava kishore Manne
2022-04-16 16:41   ` Xu Yilun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR02MB45763D1B949353F99AAFE7D8C2F39@SN6PR02MB4576.namprd02.prod.outlook.com \
    --to=navam@xilinx.com \
    --cc=git@xilinx.com \
    --cc=hao.wu@intel.com \
    --cc=joe@perches.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=michals@xilinx.com \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®