From: "Havalige, Thippeswamy" <thippeswamy.havalige@amd.com>
To: "manivannan.sadhasivam@linaro.org" <manivannan.sadhasivam@linaro.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"kw@linux.com" <kw@linux.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"Simek, Michal" <michal.simek@amd.com>,
"Gogada, Bharat Kumar" <bharat.kumar.gogada@amd.com>
Subject: RE: [PATCH 2/2] PCI: amd-mdb: Add AMD MDB Root Port driver
Date: Mon, 9 Dec 2024 09:44:15 +0000 [thread overview]
Message-ID: <SN7PR12MB72012B3F617DCE9BC398227C8B3C2@SN7PR12MB7201.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20241208125858.u2f3tk63bxmww3l6@thinkpad>
Hi Sadhasivam,
> -----Original Message-----
> From: manivannan.sadhasivam@linaro.org <manivannan.sadhasivam@linaro.org>
> Sent: Sunday, December 8, 2024 6:29 PM
> To: Havalige, Thippeswamy <thippeswamy.havalige@amd.com>
> Cc: Bjorn Helgaas <helgaas@kernel.org>; bhelgaas@google.com;
> lpieralisi@kernel.org; kw@linux.com; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; jingoohan1@gmail.com; Simek, Michal
> <michal.simek@amd.com>; Gogada, Bharat Kumar
> <bharat.kumar.gogada@amd.com>
> Subject: Re: [PATCH 2/2] PCI: amd-mdb: Add AMD MDB Root Port driver
>
> On Mon, Dec 02, 2024 at 08:21:36AM +0000, Havalige, Thippeswamy wrote:
>
> [...]
>
> > > > + d = irq_domain_get_irq_data(pcie->mdb_domain, irq);
> > > > + if (intr_cause[d->hwirq].str)
> > > > + dev_warn(dev, "%s\n", intr_cause[d->hwirq].str);
> > > > + else
> > > > + dev_warn(dev, "Unknown IRQ %ld\n", d->hwirq);
> > > > +
> > > > + return IRQ_HANDLED;
> > >
> > > I see that some of these messages are "Correctable/Non-Fatal/Fatal error
> > > message"; I assume this Root Port doesn't have an AER Capability, and this
> > > interrupt is the "System Error" controlled by the Root Control Error Enable bits in
> the
> > > PCIe Capability? (See PCIe r6.0, sec 6.2.6)
> > >
> > > Is there any way to hook this into the AER handling so we can do something
> about
> > > it, since the devices *below* the Root Port may support AER and may have
> useful
> > > information logged?
> > >
> > > Since this is DWC-based, I suppose these are general questions that apply to all
> > > the similar drivers.
> >
> >
> > Thanks for review, We have this in our plan to hook platform specific error
> interrupts
> > to AER in future will add this support.
> >
>
> So on your platform, AER (also PME) interrupts are reported over SPI interrupt
> only and not through MSI/MSI-X? Most of the DWC controllers have this weird
> behavior of reporting AER/PME only through SPI, but that should be legacy
> controllers. Newer ones does support MSI.
Thanks for your comment, Yes our platform supports platform specific Error
Interrupts over SPI.
>
> - Mani
>
> --
> மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-12-09 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 11:58 [PATCH 0/2] Add support for AMD MDB IP as Root Port Thippeswamy Havalige
2024-11-27 11:58 ` [PATCH 1/2] dt-bindings: PCI: amd-mdb: Add YAML schemas for AMD Versal2 MDB PCIe Root Port Bridge Thippeswamy Havalige
2024-11-28 7:28 ` Krzysztof Kozlowski
2024-12-02 8:23 ` Havalige, Thippeswamy
2024-11-27 11:58 ` [PATCH 2/2] PCI: amd-mdb: Add AMD MDB Root Port driver Thippeswamy Havalige
2024-11-29 20:22 ` Bjorn Helgaas
2024-12-02 8:21 ` Havalige, Thippeswamy
2024-12-08 12:58 ` manivannan.sadhasivam
2024-12-09 9:44 ` Havalige, Thippeswamy [this message]
2024-12-09 9:54 ` Manivannan Sadhasivam
2024-12-09 11:21 ` Havalige, Thippeswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN7PR12MB72012B3F617DCE9BC398227C8B3C2@SN7PR12MB7201.namprd12.prod.outlook.com \
--to=thippeswamy.havalige@amd.com \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®