mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Dravet <dravet@hotmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add
Date: Mon, 16 Jan 2012 15:28:22 -0600	[thread overview]
Message-ID: <SNT144-W1F7026BA077AA0D46B5E3DF830@phx.gbl> (raw)
In-Reply-To: <SNT144-W477468478D64073A33B390DF830@phx.gbl>


>  > This patch makes it clear that the problem is in the BIOS of 
the computer and not the kernel.  This patch applies to kernel 3.2.1.
>  >  
>  > --- dir.orig    2012-01-14 18:58:20.026745884 -0600
>  > +++ dir.c    2012-01-14 19:52:33.011444581 -0600
>  > @@ -479,6 +479,8 @@ int sysfs_add_one(struct sysfs_addrm_cxt
>  >               (path == NULL) ? sd->s_name :
>  >               strcat(strcat(sysfs_pathname(acxt->parent_sd, path), "/"),
>  >                      sd->s_name));
>  > +        WARN(1, KERN_WARNING
>  > +             "Your BIOS is broken.  Please contact your computer manufacturer.");
>  >          kfree(path);
>  >      }
>  
> That certainly isn't always the case. Incorrectly written drivers
> have also taken this codepath before now.
> 
> 	Dave

Then how do you tell when the problem is the BIOS or a driver?
Jason 		 	   		  

      parent reply	other threads:[~2012-01-16 21:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-15 15:16 Jason Dravet
2012-01-15 15:30 ` Dave Jones
     [not found]   ` <SNT144-W477468478D64073A33B390DF830@phx.gbl>
2012-01-16 21:28     ` Jason Dravet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SNT144-W1F7026BA077AA0D46B5E3DF830@phx.gbl \
    --to=dravet@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®