From: David Heidelberg <david@ixit.cz>
To: Rob Herring <robh+dt@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: ~okias/devicetree@lists.sr.ht, devicetree@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/fsl: fix the schema check errors for fsl,tmu-calibration
Date: Tue, 18 Jan 2022 15:37:04 +0100 [thread overview]
Message-ID: <SXTW5R.DQG57Y1RMSI9@ixit.cz> (raw)
In-Reply-To: <20211029121733.46849-1-david@ixit.cz>
Hello, can I ask for review please? Thanks.
David Heidelberg
On Fri, Oct 29 2021 at 14:17:33 +0200, David Heidelberg <david@ixit.cz>
wrote:
> fsl,tmu-calibration is in u32-matrix format. Use matching property
> syntax.
> No functional changes. Fixes warnings as:
> $ make dtbs_check
> ...
> arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml:
> tmu@30260000: fsl,tmu-calibration:0: Additional items are not allowed
> (1, 41, 2, 47, 3, 53, 4, 61, 5, 67, 6, 75, 7, 81, 8, 87, 9, 95, 10,
> 103, 11, 111
> , 65536, 27, 65537, 35, 65538, 43, 65539, 51, 65540, 59, 65541, 67,
> 65542, 75, 65543, 85, 65544, 93, 65545, 103, 65546, 112, 131072, 23,
> 131073, 35, 131074, 45, 131075, 55, 131076, 65, 131077, 75, 131078,
> 87, 13
> 1079, 99, 131080, 111, 196608, 21, 196609, 33, 196610, 45, 196611,
> 57, 196612, 69, 196613, 83, 196614, 95, 196615, 113 were unexpected)
> From schema:
> Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
> ...
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/powerpc/boot/dts/fsl/t1023si-post.dtsi | 79
> +++++++++++----------
> arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 71 +++++++++---------
> 2 files changed, 76 insertions(+), 74 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> index d552044c5afc..aa5152ca8120 100644
> --- a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> @@ -367,45 +367,46 @@ tmu: tmu@f0000 {
> reg = <0xf0000 0x1000>;
> interrupts = <18 2 0 0>;
> fsl,tmu-range = <0xb0000 0xa0026 0x80048 0x30061>;
> - fsl,tmu-calibration = <0x00000000 0x0000000f
> - 0x00000001 0x00000017
> - 0x00000002 0x0000001e
> - 0x00000003 0x00000026
> - 0x00000004 0x0000002e
> - 0x00000005 0x00000035
> - 0x00000006 0x0000003d
> - 0x00000007 0x00000044
> - 0x00000008 0x0000004c
> - 0x00000009 0x00000053
> - 0x0000000a 0x0000005b
> - 0x0000000b 0x00000064
> -
> - 0x00010000 0x00000011
> - 0x00010001 0x0000001c
> - 0x00010002 0x00000024
> - 0x00010003 0x0000002b
> - 0x00010004 0x00000034
> - 0x00010005 0x00000039
> - 0x00010006 0x00000042
> - 0x00010007 0x0000004c
> - 0x00010008 0x00000051
> - 0x00010009 0x0000005a
> - 0x0001000a 0x00000063
> -
> - 0x00020000 0x00000013
> - 0x00020001 0x00000019
> - 0x00020002 0x00000024
> - 0x00020003 0x0000002c
> - 0x00020004 0x00000035
> - 0x00020005 0x0000003d
> - 0x00020006 0x00000046
> - 0x00020007 0x00000050
> - 0x00020008 0x00000059
> -
> - 0x00030000 0x00000002
> - 0x00030001 0x0000000d
> - 0x00030002 0x00000019
> - 0x00030003 0x00000024>;
> + fsl,tmu-calibration =
> + <0x00000000 0x0000000f>,
> + <0x00000001 0x00000017>,
> + <0x00000002 0x0000001e>,
> + <0x00000003 0x00000026>,
> + <0x00000004 0x0000002e>,
> + <0x00000005 0x00000035>,
> + <0x00000006 0x0000003d>,
> + <0x00000007 0x00000044>,
> + <0x00000008 0x0000004c>,
> + <0x00000009 0x00000053>,
> + <0x0000000a 0x0000005b>,
> + <0x0000000b 0x00000064>,
> +
> + <0x00010000 0x00000011>,
> + <0x00010001 0x0000001c>,
> + <0x00010002 0x00000024>,
> + <0x00010003 0x0000002b>,
> + <0x00010004 0x00000034>,
> + <0x00010005 0x00000039>,
> + <0x00010006 0x00000042>,
> + <0x00010007 0x0000004c>,
> + <0x00010008 0x00000051>,
> + <0x00010009 0x0000005a>,
> + <0x0001000a 0x00000063>,
> +
> + <0x00020000 0x00000013>,
> + <0x00020001 0x00000019>,
> + <0x00020002 0x00000024>,
> + <0x00020003 0x0000002c>,
> + <0x00020004 0x00000035>,
> + <0x00020005 0x0000003d>,
> + <0x00020006 0x00000046>,
> + <0x00020007 0x00000050>,
> + <0x00020008 0x00000059>,
> +
> + <0x00030000 0x00000002>,
> + <0x00030001 0x0000000d>,
> + <0x00030002 0x00000019>,
> + <0x00030003 0x00000024>;
> #thermal-sensor-cells = <1>;
> };
>
> diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> index f58eb820eb5e..27e6985d8bde 100644
> --- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> @@ -447,41 +447,42 @@ tmu: tmu@f0000 {
> reg = <0xf0000 0x1000>;
> interrupts = <18 2 0 0>;
> fsl,tmu-range = <0xa0000 0x90026 0x8004a 0x1006a>;
> - fsl,tmu-calibration = <0x00000000 0x00000025
> - 0x00000001 0x00000028
> - 0x00000002 0x0000002d
> - 0x00000003 0x00000031
> - 0x00000004 0x00000036
> - 0x00000005 0x0000003a
> - 0x00000006 0x00000040
> - 0x00000007 0x00000044
> - 0x00000008 0x0000004a
> - 0x00000009 0x0000004f
> - 0x0000000a 0x00000054
> -
> - 0x00010000 0x0000000d
> - 0x00010001 0x00000013
> - 0x00010002 0x00000019
> - 0x00010003 0x0000001f
> - 0x00010004 0x00000025
> - 0x00010005 0x0000002d
> - 0x00010006 0x00000033
> - 0x00010007 0x00000043
> - 0x00010008 0x0000004b
> - 0x00010009 0x00000053
> -
> - 0x00020000 0x00000010
> - 0x00020001 0x00000017
> - 0x00020002 0x0000001f
> - 0x00020003 0x00000029
> - 0x00020004 0x00000031
> - 0x00020005 0x0000003c
> - 0x00020006 0x00000042
> - 0x00020007 0x0000004d
> - 0x00020008 0x00000056
> -
> - 0x00030000 0x00000012
> - 0x00030001 0x0000001d>;
> + fsl,tmu-calibration =
> + <0x00000000 0x00000025>,
> + <0x00000001 0x00000028>,
> + <0x00000002 0x0000002d>,
> + <0x00000003 0x00000031>,
> + <0x00000004 0x00000036>,
> + <0x00000005 0x0000003a>,
> + <0x00000006 0x00000040>,
> + <0x00000007 0x00000044>,
> + <0x00000008 0x0000004a>,
> + <0x00000009 0x0000004f>,
> + <0x0000000a 0x00000054>,
> +
> + <0x00010000 0x0000000d>,
> + <0x00010001 0x00000013>,
> + <0x00010002 0x00000019>,
> + <0x00010003 0x0000001f>,
> + <0x00010004 0x00000025>,
> + <0x00010005 0x0000002d>,
> + <0x00010006 0x00000033>,
> + <0x00010007 0x00000043>,
> + <0x00010008 0x0000004b>,
> + <0x00010009 0x00000053>,
> +
> + <0x00020000 0x00000010>,
> + <0x00020001 0x00000017>,
> + <0x00020002 0x0000001f>,
> + <0x00020003 0x00000029>,
> + <0x00020004 0x00000031>,
> + <0x00020005 0x0000003c>,
> + <0x00020006 0x00000042>,
> + <0x00020007 0x0000004d>,
> + <0x00020008 0x00000056>,
> +
> + <0x00030000 0x00000012>,
> + <0x00030001 0x0000001d>;
> #thermal-sensor-cells = <1>;
> };
>
> --
> 2.33.0
>
prev parent reply other threads:[~2022-01-18 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 12:17 David Heidelberg
2022-01-18 14:37 ` David Heidelberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SXTW5R.DQG57Y1RMSI9@ixit.cz \
--to=david@ixit.cz \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®