mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: YC Hsieh <yc_hsieh@aspeedtech.com>
To: Lee Jones <lee@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@codeconstruct.com.au>,
	ChiaWei Wang <chiawei_wang@aspeedtech.com>,
	Corey Minyard <corey@minyard.net>,
	Andrew Jeffery <andrew@aj.id.au>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"openipmi-developer@lists.sourceforge.net"
	<openipmi-developer@lists.sourceforge.net>
Subject: Re: [PATCH RFC 1/2] dt-bindings: mfd: aspeed-lpc: Document lpcN alias for multi-instance SoCs
Date: Mon, 10 Aug 2026 06:24:10 +0000	[thread overview]
Message-ID: <TY0PR06MB6855FDB0FC2A4353DC96C00D93DE2@TY0PR06MB6855.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20260806133111.GF2869284@google.com>

On Thu, 23 Jul 2026, Yu-Che Hsieh wrote:

>> Some SoCs (e.g. AST2700) expose more than one physical LPC controller
>> instance. Downstream devices such as KCS channels need a stable,
>> globally-unique index derived from which LPC controller instance they
>> belong to, so document the "lpcN" alias convention on the LPC
>> controller node that lets DT authors assign a fixed index per
>> instance, mirroring the existing alias-based numbering convention used
>> by mmc/i2c/spi/serial.
>>
>> Signed-off-by: Yu-Che Hsieh <yc_hsieh@aspeedtech.com>

> Why is this RFC?  What's stopping me from applying this now?

Thanks, there is no blocker. 

I marked it as RFC to gather feedback on the alias-based 
numbering convention for LPC controllers before submitting 
it as a regular patch.

If the approach looks acceptable, I'm happy to resend it 
without the RFC tag.

>> ---
>>  Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml b/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
>> index cbc3a2485a2f..81c12e0fb312 100644
>> --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
>> @@ -35,6 +35,13 @@ description:
>>    configuration, therefore the host portion of the controller is exposed as a
>>    syscon as a means to arbitrate access.
>> 
>> +  On SoCs that expose more than one LPC controller instance, it is possible to
>> +  assign a fixed index to a given instance (and thus to downstream devices
>> +  such as KCS channels that must be uniquely identified system-wide) by
>> +  defining an "lpcN" alias for it in the /aliases device tree node. If no such
> +  alias is present, the SoC is treated as having a single LPC controller
>> +  instance.
>> +
>>  properties:
>>    compatible:
>>      items:
>>
>> --
>> 2.34.1
>>
--

Yu-Che


  reply	other threads:[~2026-08-10  6:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23  5:31 [PATCH RFC 0/2] ipmi: kcs_bmc_aspeed: Support multiple LPC controller instances Yu-Che Hsieh
2026-07-23  5:31 ` [PATCH RFC 1/2] dt-bindings: mfd: aspeed-lpc: Document lpcN alias for multi-instance SoCs Yu-Che Hsieh
2026-08-06 13:31   ` Lee Jones
2026-08-10  6:24     ` YC Hsieh [this message]
2026-07-23  5:31 ` [PATCH RFC 2/2] ipmi: kcs_bmc_aspeed: Support multiple LPC controller instances Yu-Che Hsieh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY0PR06MB6855FDB0FC2A4353DC96C00D93DE2@TY0PR06MB6855.apcprd06.prod.outlook.com \
    --to=yc_hsieh@aspeedtech.com \
    --cc=andrew@aj.id.au \
    --cc=andrew@codeconstruct.com.au \
    --cc=chiawei_wang@aspeedtech.com \
    --cc=conor+dt@kernel.org \
    --cc=corey@minyard.net \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®